Merge pull request #52 from ikbear/hotfix/use_querystring

Use querystring lib and delete generateQuerystring() function

Author: xushiwei

CHANGELOG.md

@@ -1,5 +1,13 @@
 #CHANGELOG
 
+## v2.4.3
+
+2013-02-17
+
+Issue [#52](https://github.com/qiniu/nodejs-sdk/pull/52):
+
+- 去除对自定义 generateQueryString() 函数的依赖，使用 querystring 包的 stringify() 函数。
+
 ## v2.4.2
 
 Issue [#48](https://github.com/qiniu/nodejs-sdk/pull/48):

lib/rs.js

@@ -3,6 +3,7 @@ var path = require('path');
 var crc32 = require('crc32');
 var mime = require('mime');
 var formstream = require('formstream');
+var querystring = require('querystring');
 var config = require('./conf.js');
 var util = require('./util.js');
 var img = require('./img.js');
@@ -135,7 +136,7 @@ Service.prototype.uploadWithToken = function(uploadToken, stream, key, mimeType,
       "mime_type": mimeType
     };
   }
-  var callbackQueryString = util.generateQueryString(callbackParams);
+  var callbackQueryString = querystring.stringify(callbackParams);
   var url = config.UP_HOST + "/upload";
 
   var filename = path.basename(key);

lib/util.js

@@ -34,21 +34,6 @@ exports.generateActionString = function(bucket, key, mimeType, customMeta, crc32
   return actionParams;
 }
 
-exports.generateQueryString = function (params) {
-  if (params.constructor === String) {
-    return params;
-  }
-  var total_params = [];
-  for (var key in params) {
-    total_params.push(escape(key) + "=" + escape(params[key]));
-  }
-  if (total_params.length > 0) {
-    return total_params.join("&");    
-  } else {
-    return "";
-  }
-}
-
 // ------------------------------------------------------------------------------------------
 // func readAll
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "qiniu",
-  "version": "2.4.2",
+  "version": "2.4.3",
   "description": "Node wrapper for Qiniu Resource (Cloud) Storage API",
   "main": "index.js",
   "directories": {