Skip to content

Commit 1b98c3e

Browse files
committed
修改v1bug 修改测试用例问题 添加4m+1
1 parent 9c54a59 commit 1b98c3e

File tree

2 files changed

+23
-11
lines changed

2 files changed

+23
-11
lines changed

qiniu/storage/resume.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,10 @@ ResumeUploader.prototype.putStream = function (uploadToken, key, rsStream,
4545
putExtra.fname = key || '?';
4646
}
4747

48+
if (!putExtra.version) {
49+
putExtra.version = 'v1';
50+
}
51+
4852
rsStream.on('error', function (err) {
4953
// callbackFunc
5054
callbackFunc(err, null, null);
@@ -168,15 +172,15 @@ function putReq(config, uploadToken, key, rsStream, rsStreamLen, putExtra, callb
168172
var blkputRet = respBody;
169173
finishedCtxList.push(blkputRet.ctx);
170174
finishedBlkPutRets.push(blkputRet);
171-
if (putExtra.progressCallback) {
172-
putExtra.progressCallback(readLen, rsStreamLen);
173-
}
174175
if (putExtra.resumeRecordFile) {
175176
var contents = JSON.stringify(finishedBlkPutRets);
176177
fs.writeFileSync(putExtra.resumeRecordFile, contents, {
177178
encoding: 'utf-8'
178179
});
179180
}
181+
if (putExtra.progressCallback) {
182+
putExtra.progressCallback(readLen, rsStreamLen);
183+
}
180184
blkStream.resume();
181185
if (finishedCtxList.length === totalBlockNum) {
182186
mkfileReq(upDomain, uploadToken, rsStreamLen, finishedCtxList, key, putExtra, callbackFunc);

test/resume_up.test.js

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,8 @@ describe('test resume up', function () {
7373
console.log(respBody, respInfo);
7474
should.not.exist(respErr);
7575
respBody.should.have.keys('key', 'hash');
76-
keysToDelete.push(respBody.key);
76+
console.log(respBody.key)
77+
keysToDelete.push("1",respBody.key);
7778
done();
7879
});
7980
});
@@ -89,6 +90,7 @@ describe('test resume up', function () {
8990
console.log(respBody, respInfo);
9091
should.not.exist(respErr);
9192
respBody.should.have.keys('key', 'hash');
93+
console.log("2",respBody.key)
9294
keysToDelete.push(respBody.key);
9395
done();
9496
});
@@ -132,6 +134,7 @@ describe('test resume up', function () {
132134

133135
describe('test resume up#putStream', function () {
134136
// eslint-disable-next-line no-undef
137+
this.timeout(0)
135138
it('test resume up#putStream', function (done) {
136139
var key = 'storage_putStream_test' + Math.random(1000);
137140
var stream = new Readable();
@@ -142,9 +145,7 @@ describe('test resume up', function () {
142145
}
143146
stream.push(null);
144147
resumeUploader.putStream(uploadToken, key, stream, blkCnt * blkSize, putExtra,
145-
function (
146-
respErr,
147-
respBody, respInfo) {
148+
function (respErr, respBody, respInfo) {
148149
console.log(respBody, respInfo);
149150
should.not.exist(respErr);
150151
respBody.should.have.keys('key', 'hash');
@@ -175,20 +176,24 @@ describe('test resume up', function () {
175176
done();
176177
});
177178
});
179+
});
178180

181+
describe('test resume up#putStream resume', function () {
182+
this.timeout(0)
179183
it('test resume up#putStream resume', function (done) {
180184
config.zone = null;
181185
var key = 'storage_putStream_resume_test' + Math.random(1000);
182186
var stream = new Readable();
183187
var blkSize = 1024 * 1024;
184-
var blkCnt = 5;
188+
var blkCnt = 4;
185189
for (var i = 0; i < blkCnt; i++) {
186190
stream.push(crypto.randomBytes(blkSize));
187191
}
188192
stream.push(null);
189193
var tmpfile = path.join(os.tmpdir(), '/resume_file');
190194
fs.writeFileSync(tmpfile, '');
191195
putExtra.resumeRecordFile = tmpfile;
196+
putExtra.version = 'v1';
192197
putExtra.progressCallback = function (len, total) {
193198
if (len === total) {
194199
var content = fs.readFileSync(tmpfile);
@@ -213,7 +218,7 @@ describe('test resume up', function () {
213218
it('test resume up#putStream resume_v2', function (done) {
214219
config.zone = null;
215220
var blkSize = 1024 * 1024;
216-
var blkCnt = [2,4,6,10];
221+
var blkCnt = [2,4,4.1,6,10];
217222
var tmpfile = path.join(os.tmpdir(), '/resume_file');
218223
fs.writeFileSync(tmpfile, '');
219224
putExtra.resumeRecordFile = tmpfile;
@@ -233,6 +238,9 @@ describe('test resume up', function () {
233238
for (var j = 0; j < i; j++) {
234239
stream.push(crypto.randomBytes(blkSize));
235240
}
241+
if (i ===+i && i !==(i|0)) {
242+
stream.push('0f');
243+
}
236244
stream.push(null);
237245
var key = 'storage_putStream_resume_test_v2' + Math.random(1000);
238246
resumeUploader.putStream(uploadToken, key, stream, i * blkSize, putExtra,
@@ -243,9 +251,9 @@ describe('test resume up', function () {
243251
should.not.exist(respErr);
244252
respBody.should.have.keys('key', 'hash');
245253
keysToDelete.push(respBody.key);
246-
done();
247254
});
248255
});
256+
done();
249257
});
250-
});
258+
})
251259
});

0 commit comments

Comments
 (0)