querystring

Author: lintianzhi

qiniu/fop.js

@@ -1,6 +1,8 @@
 var util = require('./util');
 var rpc = require('./rpc');
 
+var querystring = require('querystring');
+
 exports.ImageView = ImageView;
 exports.ImageInfo = ImageInfo;
 exports.Exif = Exif;
@@ -54,11 +56,23 @@ Exif.prototype.makeRequest = function(url) {
 function pfop(bucket, key, fops, opts, onret) {
 
   opts = opts || {};
-  var notifyStr = '&notifyURL=' + opts.notifyURL || '';
-  var forceStr = opts.force && '&force=1' || '';
+
+  param = {
+    bucket: bucket,
+    key: key,
+    fops: fops
+  };
+  if (opts.notifyURL) {
+    param.notifyURL = opts.notifyURL;
+  } else {
+    param.notifyURL = 'www.test.com';
+  }
+  if (opts.force) {
+    param.force = 1;
+  }
 
   var uri = 'http://api.qiniu.com/pfop/';
-  var body = 'bucket='+bucket+'&key='+key+'&fops='+fops+ notifyStr + forceStr;
+  var body = querystring.stringify(param);
   var auth = util.generateAccessToken(uri, body);
   rpc.postWithForm(uri, body, auth, onret);
 }

test/io.test.js

@@ -138,7 +138,7 @@ describe('test start step1:', function() {
     it('do pfop', function(done) {
 // @gist pfop
 // pfop
-      qiniu.fop.pfop(TEST_BUCKET, keys[0], 'avinfo', {notifyUrl: 'www.test.com', force: true}, function(err, ret) {
+      qiniu.fop.pfop(TEST_BUCKET, keys[0], 'avinfo', {notifyURL: 'www.test.com'}, function(err, ret) {
         ret.should.have.keys('persistentId');
         done();
       });