fix httpc re-export and add test for needRetry

Author: lihsai0

index.js

@@ -10,8 +10,8 @@ module.exports = {
     conf: require('./qiniu/conf.js'),
     httpc: {
         middleware: require('./qiniu/httpc/middleware'),
-        client: require('./qiniu/httpc/client'),
-        responseWrapper: require('./qiniu/httpc/responseWrapper')
+        HttpClient: require('./qiniu/httpc/client').HttpClient,
+        ResponseWrapper: require('./qiniu/httpc/responseWrapper').ResponseWrapper
     },
     rpc: require('./qiniu/rpc.js'),
     util: require('./qiniu/util.js'),

qiniu/httpc/responseWrapper.js

@@ -17,14 +17,14 @@ ResponseWrapper.prototype.ok = function () {
  * @return {boolean}
  */
 ResponseWrapper.prototype.needRetry = function () {
-    if (!this.resp || !this.resp.statusCode) {
-        return true;
-    }
-
     if (this.ok()) {
         return false;
     }
 
+    if (!this.resp || !this.resp.statusCode || this.resp.statusCode < 0) {
+        return true;
+    }
+
     const statusCode = this.resp.statusCode;
 
     // 需要重试的特例

test/http.test.js test/httpc.test.jstest/http.test.js renamed to test/httpc.test.js

@@ -8,6 +8,59 @@ const {
 } = qiniu.httpc.middleware;
 
 describe('test http module', function () {
+    describe('test http ResponseWrapper', function () {
+        const { ResponseWrapper } = qiniu.httpc;
+
+        it('needRetry', function () {
+            const rule = [
+                ['-1', true],
+                ['100,499', false],
+                ['500,578', true],
+                ['579', false],
+                ['580,599', true],
+                ['600,611', true],
+                ['612', false],
+                ['613,630', true],
+                ['631', false],
+                ['632,699', true]
+            ];
+            const cases = [];
+            for (const [codeRange, shouldRetry] of rule) {
+                let [start, end] = codeRange.split(',');
+                start = parseInt(start);
+                end = parseInt(end);
+                if (!end) {
+                    cases.push({
+                        code: start,
+                        shouldRetry
+                    });
+                } else {
+                    for (let i = start; i <= end; i++) {
+                        cases.push({
+                            code: i,
+                            shouldRetry
+                        });
+                    }
+                }
+            }
+
+            const mockedResponseWrapper = new ResponseWrapper({
+                data: [],
+                resp: {
+                    statusCode: 200
+                }
+            });
+
+            for (const item of cases) {
+                mockedResponseWrapper.resp.statusCode = item.code;
+                mockedResponseWrapper.needRetry().should.eql(
+                    item.shouldRetry,
+                    `${item.code} need${item.shouldRetry ? '' : ' NOT'} retry`
+                );
+            }
+        });
+    });
+
     class OrderRecordMiddleware extends Middleware {
         /**
          *