Skip to content

Commit bc642cf

Browse files
authored
NFC: Remove stale code from external objects handling (JuliaLang#53009)
Thanks to @gbaraldi for pointing this out.
1 parent 4d26be0 commit bc642cf

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

src/staticdata.c

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -312,8 +312,6 @@ static uintptr_t nsym_tag;
312312
// array of definitions for the predefined tagged object types
313313
// (reverse of symbol_table)
314314
static arraylist_t deser_sym;
315-
// Predefined tags that do not have special handling in `externally_linked`
316-
static htable_t external_objects;
317315

318316
static htable_t serialization_order; // to break cycles, mark all objects that are serialized
319317
static htable_t nullptrs;
@@ -2661,13 +2659,6 @@ static void jl_save_system_image_to_stream(ios_t *f, jl_array_t *mod_array,
26612659
jl_queue_for_serialization(&s, s.ptls->root_task->tls);
26622660
}
26632661
else {
2664-
// To ensure we don't have to manually update the list, go through all tags and queue any that are not otherwise
2665-
// judged to be externally-linked
2666-
htable_new(&external_objects, NUM_TAGS);
2667-
for (size_t i = 0; tags[i] != NULL; i++) {
2668-
jl_value_t *tag = *tags[i];
2669-
ptrhash_put(&external_objects, tag, tag);
2670-
}
26712662
// Queue the worklist itself as the first item we serialize
26722663
jl_queue_for_serialization(&s, worklist);
26732664
jl_queue_for_serialization(&s, jl_module_init_order);
@@ -2871,8 +2862,6 @@ static void jl_save_system_image_to_stream(ios_t *f, jl_array_t *mod_array,
28712862
arraylist_free(&gvars);
28722863
arraylist_free(&external_fns);
28732864
htable_free(&field_replace);
2874-
if (worklist)
2875-
htable_free(&external_objects);
28762865
htable_free(&serialization_order);
28772866
htable_free(&nullptrs);
28782867
htable_free(&symbol_table);

0 commit comments

Comments
 (0)