SIL: remove a workaround for a Windows 5.10 host compiler crash

swiftlang#73253 should be fixed in 6.0, which is now used as host compiler.

Author: eeckstein

SwiftCompilerSources/Sources/Optimizer/InstructionSimplification/SimplifyConvertEscapeToNoEscape.swift

@@ -28,10 +28,6 @@ private extension ConvertEscapeToNoEscapeInst {
   ///   %3 = thin_to_thick_function %1 to $@noescape () -> ()
 
   func tryCombineWithThinToThickOperand(_ context: SimplifyContext) {
-    // compiling bridged.getFunctionTypeWithNoEscape crashes the 5.10 Windows compiler
-#if !os(Windows)
-    // TODO: https://github.com/apple/swift/issues/73253
-
     if let thinToThick = fromFunction as? ThinToThickFunctionInst {
       let builder = Builder(before: self, context)
       let noEscapeFnType = thinToThick.type.getFunctionType(withNoEscape: true)
@@ -40,6 +36,5 @@ private extension ConvertEscapeToNoEscapeInst {
       uses.replaceAll(with: newThinToThick, context)
       context.erase(instruction: self)
     }
-#endif
   }
 }

SwiftCompilerSources/Sources/SIL/Type.swift

@@ -99,14 +99,10 @@ public struct Type : TypeProperties, CustomStringConvertible, NoReflectionChildr
     GenericSignature(bridged: bridged.getInvocationGenericSignatureOfFunctionType())
   }
 
-  // compiling bridged.getFunctionTypeWithNoEscape crashes the 5.10 Windows compiler
-  // TODO: https://github.com/apple/swift/issues/73253
-  #if !os(Windows)
-    // Returns a new SILFunctionType with changed "escapeness".
-    public func getFunctionType(withNoEscape: Bool) -> Type {
-      bridged.getFunctionTypeWithNoEscape(withNoEscape).type
-    }
-  #endif
+  // Returns a new SILFunctionType with changed "escapeness".
+  public func getFunctionType(withNoEscape: Bool) -> Type {
+    bridged.getFunctionTypeWithNoEscape(withNoEscape).type
+  }
 
   //===--------------------------------------------------------------------===//
   //                           Aggregates