SIL: make SILFunctionConvention constructible without needing a SIL function

Add an initializer which takes the `hasLoweredAddresses` directly and add `Context.moduleHasLoweredAddresses`

Author: eeckstein

SwiftCompilerSources/Sources/Optimizer/PassManager/Context.swift

@@ -50,6 +50,8 @@ extension Context {
 
   var moduleIsSerialized: Bool { _bridged.moduleIsSerialized() }
 
+  var moduleHasLoweredAddresses: Bool { _bridged.moduleHasLoweredAddresses() }
+
   /// Enable diagnostics requiring WMO (for @noLocks, @noAllocation
   /// annotations, Embedded Swift, and class specialization). SourceKit is the
   /// only consumer that has this disabled today (as it disables WMO

SwiftCompilerSources/Sources/SIL/FunctionConvention.swift

@@ -26,10 +26,14 @@ public struct FunctionConvention : CustomStringConvertible {
   let functionType: CanonicalType
   let hasLoweredAddresses: Bool
 
-  init(for functionType: CanonicalType, in function: Function) {
+  public init(for functionType: CanonicalType, in function: Function) {
+    self.init(for: functionType, hasLoweredAddresses: function.hasLoweredAddresses)
+  }
+
+  public init(for functionType: CanonicalType, hasLoweredAddresses: Bool) {
     assert(!functionType.hasTypeParameter, "requires contextual type")
     self.functionType = functionType
-    self.hasLoweredAddresses = function.hasLoweredAddresses
+    self.hasLoweredAddresses = hasLoweredAddresses
   }
 
   /// All results including the error.
@@ -209,7 +213,7 @@ public struct ParameterInfo : CustomStringConvertible {
 }
 
 extension FunctionConvention {
-  public struct Parameters : Collection {
+  public struct Parameters : RandomAccessCollection {
     let bridged: BridgedParameterInfoArray
     let hasLoweredAddresses: Bool
 

include/swift/SILOptimizer/OptimizerBridging.h

@@ -205,6 +205,7 @@ struct BridgedPassContext {
   BRIDGED_INLINE SILStage getSILStage() const;
   BRIDGED_INLINE bool hadError() const;
   BRIDGED_INLINE bool moduleIsSerialized() const;
+  BRIDGED_INLINE bool moduleHasLoweredAddresses() const;
   BRIDGED_INLINE bool isTransforming(BridgedFunction function) const;
 
   // Analysis

include/swift/SILOptimizer/OptimizerBridgingImpl.h

@@ -183,6 +183,10 @@ bool BridgedPassContext::moduleIsSerialized() const {
   return invocation->getPassManager()->getModule()->isSerialized();
 }
 
+bool BridgedPassContext::moduleHasLoweredAddresses() const {
+  return invocation->getPassManager()->getModule()->useLoweredAddresses();
+}
+
 bool BridgedPassContext::isTransforming(BridgedFunction function) const {
   return invocation->getFunction() == function.getFunction();
 }