[AST] Fix DeclBaseName::compare()

cachemeifyoucan · cachemeifyoucan · commit f53c6a481d2b · 2025-03-26T20:14:16.000-07:00
Fix `DeclBaseName::compare()` to not return equal on two base names of
different kinds but have the same user facing names.
diff --git a/include/swift/AST/Identifier.h b/include/swift/AST/Identifier.h
@@ -385,7 +385,11 @@ class DeclBaseName {
   }
 
   int compare(DeclBaseName other) const {
-    return userFacingName().compare(other.userFacingName());
+    if (int result = userFacingName().compare(other.userFacingName()))
+      return result;
+    if (getKind() == other.getKind())
+      return 0;
+    return getKind() < other.getKind() ? -1 : 1;
   }
 
   bool operator==(StringRef Str) const {

Original file line number	Diff line number	Diff line change
`@@ -385,7 +385,11 @@ class DeclBaseName {`
`385`	`385`	`}`
`386`	`386`
`387`	`387`	`int compare(DeclBaseName other) const {`
`388`		`- return userFacingName().compare(other.userFacingName());`
	`388`	`+ if (int result = userFacingName().compare(other.userFacingName()))`
	`389`	`+ return result;`
	`390`	`+ if (getKind() == other.getKind())`
	`391`	`+ return 0;`
	`392`	`+ return getKind() < other.getKind() ? -1 : 1;`
`389`	`393`	`}`
`390`	`394`
`391`	`395`	`bool operator==(StringRef Str) const {`