Skip to content
This repository was archived by the owner on Aug 13, 2025. It is now read-only.

Commit ace3e40

Browse files
Make symbol test insensitive to package naming
It's undefined whether ELF cores spell the user package as cl-user versus common-lisp-user, or whether a package qualifier is even used at all in the C linker symbol. PiperOrigin-RevId: 627426967
1 parent 3b97692 commit ace3e40

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313

1414
load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
1515
load("@bazel_skylib//rules:common_settings.bzl", "bool_flag")
16-
load("@io_bazel_stardoc//stardoc:stardoc.bzl", "stardoc")
1716
load("@bazel_tools//tools/build_defs/license:license.bzl", "license")
17+
load("@io_bazel_stardoc//stardoc:stardoc.bzl", "stardoc")
1818

1919
package(default_applicable_licenses = ["//:license"])
2020

rule-tests/BUILD

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,10 @@
11
load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
2+
load(
3+
"//:rules.bzl",
4+
"lisp_binary",
5+
"lisp_library",
6+
"lisp_test",
7+
)
28
load(
39
":tests.bzl",
410
"DYNSPACE",
@@ -12,12 +18,6 @@ load(
1218
"lisp_instrumented_files_info_test",
1319
"lisp_providers_test",
1420
)
15-
load(
16-
"//:rules.bzl",
17-
"lisp_binary",
18-
"lisp_library",
19-
"lisp_test",
20-
)
2121

2222
package(default_applicable_licenses = ["//:license"])
2323

rules.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ The three rules defined here are:
1212
lisp_test - Outputs a binary that is run with the test command
1313
"""
1414

15-
load("@rules_cc//cc:find_cc_toolchain.bzl", "find_cc_toolchain", "use_cc_toolchain")
1615
load("@bazel_skylib//rules:common_settings.bzl", "BuildSettingInfo")
16+
load("@rules_cc//cc:find_cc_toolchain.bzl", "find_cc_toolchain", "use_cc_toolchain")
1717
load(
1818
":provider.bzl",
1919
"LispInfo",

test/check_symbols.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ if ! nm $TEST_SRCDIR/google3/third_party/lisp/bazel/test/test |
1414
fi
1515

1616
if ! nm $TEST_SRCDIR/google3/third_party/lisp/bazel/test/test |
17-
grep -q ' (flet sub-zot in common-lisp-user::zot)'; then
17+
grep -q ' (flet sub-zot in .*zot)'; then
1818
echo "Failed to find expected lisp symbol in symbol table"
1919
exit 1
2020
fi

0 commit comments

Comments
 (0)