refactor(plugins): reduce nesting in collect_autoload_paths

Extract collect_psr_paths and collect_string_array_paths helpers to
address qlty nested-control-flow and function-complexity findings.

Author: sinemacula-ben

qlty-check/src/tool/php/composer.rs

@@ -291,54 +291,55 @@ impl Composer {
         let mut paths = vec![];
 
         for section in &["autoload", "autoload-dev"] {
-            if let Some(autoload) = composer_json.get(section) {
-                for key in &["psr-4", "psr-0"] {
-                    if let Some(mappings) = autoload.get(key).and_then(|v| v.as_object()) {
-                        for (_, path_value) in mappings {
-                            match path_value {
-                                Value::String(s) if !s.is_empty() => {
-                                    paths.push(s.trim_end_matches('/').to_string());
-                                }
-                                Value::Array(arr) => {
-                                    for v in arr {
-                                        if let Some(s) = v.as_str() {
-                                            if !s.is_empty() {
-                                                paths.push(
-                                                    s.trim_end_matches('/').to_string(),
-                                                );
-                                            }
-                                        }
-                                    }
-                                }
-                                _ => {}
-                            }
-                        }
-                    }
-                }
+            let Some(autoload) = composer_json.get(section) else {
+                continue;
+            };
 
-                if let Some(classmap) = autoload.get("classmap").and_then(|v| v.as_array()) {
-                    for v in classmap {
-                        if let Some(s) = v.as_str() {
-                            if !s.is_empty() {
-                                paths.push(s.trim_end_matches('/').to_string());
-                            }
-                        }
+            for key in &["psr-4", "psr-0"] {
+                if let Some(mappings) = autoload.get(key).and_then(|v| v.as_object()) {
+                    for (_, path_value) in mappings {
+                        Self::collect_psr_paths(path_value, &mut paths);
                     }
                 }
+            }
 
-                if let Some(files) = autoload.get("files").and_then(|v| v.as_array()) {
-                    for v in files {
-                        if let Some(s) = v.as_str() {
-                            if !s.is_empty() {
-                                paths.push(s.to_string());
-                            }
-                        }
-                    }
+            Self::collect_string_array_paths(autoload.get("classmap"), true, &mut paths);
+            Self::collect_string_array_paths(autoload.get("files"), false, &mut paths);
+        }
+
+        paths
+    }
+
+    fn collect_psr_paths(path_value: &Value, paths: &mut Vec<String>) {
+        match path_value {
+            Value::String(s) if !s.is_empty() => {
+                paths.push(s.trim_end_matches('/').to_string());
+            }
+            Value::Array(arr) => {
+                for s in arr.iter().filter_map(|v| v.as_str()).filter(|s| !s.is_empty()) {
+                    paths.push(s.trim_end_matches('/').to_string());
                 }
             }
+            _ => {}
         }
+    }
 
-        paths
+    fn collect_string_array_paths(
+        value: Option<&Value>,
+        trim_trailing_slash: bool,
+        paths: &mut Vec<String>,
+    ) {
+        let Some(arr) = value.and_then(|v| v.as_array()) else {
+            return;
+        };
+
+        for s in arr.iter().filter_map(|v| v.as_str()).filter(|s| !s.is_empty()) {
+            if trim_trailing_slash {
+                paths.push(s.trim_end_matches('/').to_string());
+            } else {
+                paths.push(s.to_string());
+            }
+        }
     }
 }