Fix: fix off-by-one error in ast-grep parsing: convert 0-indexed line/column numbers to 1-indexed (#2738)

Fixes #2737

`ast-grep` uses 0-based indices in its file + column output. However,
qlty expects 1-based indexes. This was leading to off-by-one errors. The
trufflehog parser shows how to implement this correctly by adding one to
everything. This also fixes another issue where invalid columns (0)
would cause the `snippet` not to show in the output, as can be seen in
the jest snapshot diff below.

This bug was leading to pretty critical lint issues not being caught at
work :(

This PR fixes the appropriate part of the code and updates the tests.
The `jest` snapshot / integration test below didn't have a snippet prior
to the fix because `0` is not considered a valid column. So this also
fixes that bug as well :)

Author: samwightt

qlty-check/src/parser/ast_grep.rs

@@ -60,10 +60,12 @@ impl Parser for AstGrep {
             let location = Some(Location {
                 path: ast_grep_issue.file.clone(),
                 range: Some(Range {
-                    start_line: ast_grep_issue.range.start.line,
-                    start_column: ast_grep_issue.range.start.column,
-                    end_line: ast_grep_issue.range.end.line,
-                    end_column: ast_grep_issue.range.end.column,
+                    // ast-grep outputs 0-indexed line/column numbers,
+                    // but qlty expects 1-indexed values.
+                    start_line: ast_grep_issue.range.start.line + 1,
+                    start_column: ast_grep_issue.range.start.column + 1,
+                    end_line: ast_grep_issue.range.end.line + 1,
+                    end_column: ast_grep_issue.range.end.column + 1,
                     ..Default::default()
                 }),
             });
@@ -104,6 +106,40 @@ impl Parser for AstGrep {
 mod test {
     use super::*;
 
+    #[test]
+    fn parse_line_numbers_are_one_indexed() {
+        // ast-grep outputs 0-indexed line/column numbers.
+        // qlty expects 1-indexed. Verify the parser converts correctly.
+        let input = r#"[{
+            "text": "argument :foo, String",
+            "range": {
+                "byteOffset": { "start": 0, "end": 20 },
+                "start": { "line": 0, "column": 0 },
+                "end": { "line": 0, "column": 20 }
+            },
+            "file": "test.rb",
+            "lines": "argument :foo, String",
+            "charCount": { "leading": 0, "trailing": 0 },
+            "language": "Ruby",
+            "metaVariables": { "single": {}, "multi": {}, "transformed": {} },
+            "ruleId": "test-rule",
+            "severity": "error",
+            "note": null,
+            "message": "test message",
+            "labels": []
+        }]"#;
+
+        let issues = AstGrep::default().parse("ast-grep", input).unwrap();
+        assert_eq!(issues.len(), 1);
+
+        let range = issues[0].location.as_ref().unwrap().range.as_ref().unwrap();
+        // Line 0 in ast-grep should become line 1 in qlty
+        assert_eq!(range.start_line, 1, "start_line should be 1-indexed");
+        assert_eq!(range.end_line, 1, "end_line should be 1-indexed");
+        assert_eq!(range.start_column, 1, "start_column should be 1-indexed");
+        assert_eq!(range.end_column, 21, "end_column should be 1-indexed");
+    }
+
     #[test]
     fn parse() {
         let input = r###"
@@ -210,9 +246,10 @@ mod test {
           location:
             path: sample.ts
             range:
-              startLine: 2
-              endLine: 2
-              endColumn: 26
+              startLine: 3
+              startColumn: 1
+              endLine: 3
+              endColumn: 27
         "#);
     }
 }

qlty-plugins/plugins/linters/ast-grep/fixtures/__snapshots__/basic_v0.37.0.shot

@@ -9,14 +9,16 @@ exports[`linter=ast-grep fixture=basic version=0.37.0 1`] = `
       "location": {
         "path": "sample.ts",
         "range": {
-          "endColumn": 26,
-          "endLine": 2,
-          "startLine": 2,
+          "endColumn": 27,
+          "endLine": 3,
+          "startColumn": 1,
+          "startLine": 3,
         },
       },
       "message": "AST pattern match found: no-await-in-promise-all",
       "mode": "MODE_BLOCK",
       "ruleKey": "no-await-in-promise-all",
+      "snippet": "Promise.all([await foo()]);",
       "snippetWithContext": "async function foo() {}
 
 Promise.all([await foo()]);