Skip to content

Commit b403062

Browse files
schuaydrashna
andauthored
Apply suggestions from code review
Co-authored-by: Drashna Jaelre <[email protected]>
1 parent fb44009 commit b403062

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

keyboards/cirrus40/cirrus40.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,8 @@
33

44
#include QMK_KEYBOARD_H
55

6-
#include "quantum.h"
76

87
#ifdef ENCODER_ENABLE
9-
extern volatile bool isLeftHand;
108
// It would be nice if QMK would expose these:
119
static bool encoder_pins_are_initialized = false; // Whether custom initialization ran.
1210
static pin_t encoders_pad_a_l[] = ENCODER_A_PINS;
@@ -30,8 +28,8 @@ void encoder_quadrature_init_pin(uint8_t index, bool pad_b) {
3028
static_assert(sizeof(encoders_pad_b_l) / sizeof(encoders_pad_b_l[0]) == 1);
3129
static_assert(sizeof(encoders_pad_a_r) / sizeof(encoders_pad_a_r[0]) == 1);
3230
static_assert(sizeof(encoders_pad_b_r) / sizeof(encoders_pad_b_r[0]) == 1);
33-
encoders_pad_a = isLeftHand ? encoders_pad_a_l : encoders_pad_a_r;
34-
encoders_pad_b = isLeftHand ? encoders_pad_b_l : encoders_pad_b_r;
31+
encoders_pad_a = is_keyboard_left() ? encoders_pad_a_l : encoders_pad_a_r;
32+
encoders_pad_b = is_keyboard_left() ? encoders_pad_b_l : encoders_pad_b_r;
3533
encoder_pins_are_initialized = true;
3634
}
3735
assert(index == 0);

keyboards/cirrus40/keyboard.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@
1515
"extrakey": true,
1616
"nkro": true
1717
},
18-
"build": {
19-
"lto": true
20-
},
2118
"host": {
2219
"default": {
2320
"nkro": true

0 commit comments

Comments
 (0)