[Dataset Quality]Fix ES issue with index template updates (elastic#231615)

## Summary

closes elastic#231478
closes elastic#231477

As part of this [PR](elastic#231407), i
fixed the issue but
[realised](https://github.com/elastic/kibana/pull/231394/files#diff-b0b75c67a5e67b5f0d2ab1bfc8cd4cd866485a6486d31c6a2b0deafc42beed05R116)
there are more fields which are causing issue. Hence removing the
exhaustive list of keys which are causing issues

---------

Co-authored-by: kibanamachine <[email protected]>

Author: 2 people

x-pack/solutions/observability/test/dataset_quality_api_integration/tests/data_streams/es_utils.ts

@@ -6,6 +6,7 @@
  */
 
 import { Client } from '@elastic/elasticsearch';
+import type { IndicesIndexTemplate } from '@elastic/elasticsearch/lib/api/types';
 
 export async function addIntegrationToLogIndexTemplate({
   esClient,
@@ -20,24 +21,33 @@ export async function addIntegrationToLogIndexTemplate({
     name: 'logs',
   });
 
-  const template = indexTemplates[0].index_template;
-  // @ts-expect-error `created_date` is a system-managed property that cannot be set
-  delete template.created_date;
+  // Remove properties from the GET response that cannot be in the PUT request
+  const {
+    created_date: createdDate,
+    modification_date: modificationDate,
+    created_date_millis: createdDateMillis,
+    modified_date_millis: modifiedDateMillis,
+    ...safeTemplate
+  } = indexTemplates[0].index_template as IndicesIndexTemplate & {
+    created_date: number;
+    created_date_millis: number;
+    modification_date: number;
+    modified_date_millis: number;
+  };
 
   await esClient.indices.putIndexTemplate({
     name: 'logs',
-    ...template,
+    ...safeTemplate,
     _meta: {
-      ...indexTemplates[0].index_template._meta,
+      ...safeTemplate._meta,
       package: {
         name,
       },
       managed_by: managedBy,
     },
     // PUT expects string[] while GET might return string | string[]
-    ignore_missing_component_templates: indexTemplates[0].index_template
-      .ignore_missing_component_templates
-      ? [indexTemplates[0].index_template.ignore_missing_component_templates].flat()
+    ignore_missing_component_templates: safeTemplate.ignore_missing_component_templates
+      ? [safeTemplate.ignore_missing_component_templates].flat()
       : undefined,
   });
 }
@@ -47,22 +57,31 @@ export async function cleanLogIndexTemplate({ esClient }: { esClient: Client })
     name: 'logs',
   });
 
-  const template = indexTemplates[0].index_template;
-  // @ts-expect-error `created_date` is a system-managed property that cannot be set
-  delete template.created_date;
+  // Remove properties from the GET response that cannot be in the PUT request
+  const {
+    created_date: createdDate,
+    modification_date: modificationDate,
+    created_date_millis: createdDateMillis,
+    modified_date_millis: modifiedDateMillis,
+    ...safeTemplate
+  } = indexTemplates[0].index_template as IndicesIndexTemplate & {
+    created_date: number;
+    created_date_millis: number;
+    modification_date: number;
+    modified_date_millis: number;
+  };
 
   await esClient.indices.putIndexTemplate({
     name: 'logs',
-    ...template,
+    ...safeTemplate,
     _meta: {
-      ...indexTemplates[0].index_template._meta,
+      ...safeTemplate._meta,
       package: undefined,
       managed_by: undefined,
     },
     // PUT expects string[] while GET might return string | string[]
-    ignore_missing_component_templates: indexTemplates[0].index_template
-      .ignore_missing_component_templates
-      ? [indexTemplates[0].index_template.ignore_missing_component_templates].flat()
+    ignore_missing_component_templates: safeTemplate.ignore_missing_component_templates
+      ? [safeTemplate.ignore_missing_component_templates].flat()
       : undefined,
   });
 }