workflow-parallel-limit.test.tsx

/**
 * MAX_PARALLEL_LIMIT Configuration Bug Test
 *
 * This test reproduces and verifies the fix for issue #23083:
 * MAX_PARALLEL_LIMIT environment variable does not take effect in iteration panel
 */

import { render, screen } from '@testing-library/react'
import * as React from 'react'

// Mock environment variables before importing constants
const originalEnv = process.env.NEXT_PUBLIC_MAX_PARALLEL_LIMIT

// Test with different environment values
function setupEnvironment(value?: string) {
  if (value)
    process.env.NEXT_PUBLIC_MAX_PARALLEL_LIMIT = value
  else
    delete process.env.NEXT_PUBLIC_MAX_PARALLEL_LIMIT

  // Clear module cache to force re-evaluation
  vi.resetModules()
}

function restoreEnvironment() {
  if (originalEnv)
    process.env.NEXT_PUBLIC_MAX_PARALLEL_LIMIT = originalEnv
  else
    delete process.env.NEXT_PUBLIC_MAX_PARALLEL_LIMIT

  vi.resetModules()
}

// Mock i18next with proper implementation
vi.mock('react-i18next', () => ({
  useTranslation: () => ({
    t: (key: string) => {
      if (key.includes('MaxParallelismTitle'))
        return 'Max Parallelism'
      if (key.includes('MaxParallelismDesc'))
        return 'Maximum number of parallel executions'
      if (key.includes('parallelMode'))
        return 'Parallel Mode'
      if (key.includes('parallelPanelDesc'))
        return 'Enable parallel execution'
      if (key.includes('errorResponseMethod'))
        return 'Error Response Method'
      return key
    },
  }),
  initReactI18next: {
    type: '3rdParty',
    init: vi.fn(),
  },
}))

// Mock i18next module completely to prevent initialization issues
vi.mock('i18next', () => ({
  use: vi.fn().mockReturnThis(),
  init: vi.fn().mockReturnThis(),
  t: vi.fn(key => key),
  isInitialized: true,
}))

// Mock the useConfig hook
vi.mock('@/app/components/workflow/nodes/iteration/use-config', () => ({
  default: () => ({
    inputs: {
      is_parallel: true,
      parallel_nums: 5,
      error_handle_mode: 'terminated',
    },
    changeParallel: vi.fn(),
    changeParallelNums: vi.fn(),
    changeErrorHandleMode: vi.fn(),
  }),
}))

// Mock other components
vi.mock('@/app/components/workflow/nodes/_base/components/variable/var-reference-picker', () => ({
  default: function MockVarReferencePicker() {
    return <div data-testid="var-reference-picker">VarReferencePicker</div>
  },
}))

vi.mock('@/app/components/workflow/nodes/_base/components/split', () => ({
  default: function MockSplit() {
    return <div data-testid="split">Split</div>
  },
}))

vi.mock('@/app/components/workflow/nodes/_base/components/field', () => ({
  default: function MockField({ title, children }: { title: string, children: React.ReactNode }) {
    return (
      <div data-testid="field">
        <label>{title}</label>
        {children}
      </div>
    )
  },
}))

const getParallelControls = () => ({
  numberInput: screen.getByRole('spinbutton'),
  slider: screen.getByRole('slider'),
})

describe('MAX_PARALLEL_LIMIT Configuration Bug', () => {
  const mockNodeData = {
    id: 'test-iteration-node',
    type: 'iteration' as const,
    data: {
      title: 'Test Iteration',
      desc: 'Test iteration node',
      iterator_selector: ['test'],
      output_selector: ['output'],
      is_parallel: true,
      parallel_nums: 5,
      error_handle_mode: 'terminated' as const,
    },
  }

  beforeEach(() => {
    vi.clearAllMocks()
  })

  afterEach(() => {
    restoreEnvironment()
  })

  afterAll(() => {
    restoreEnvironment()
  })

  describe('Environment Variable Parsing', () => {
    it('should parse MAX_PARALLEL_LIMIT from NEXT_PUBLIC_MAX_PARALLEL_LIMIT environment variable', async () => {
      setupEnvironment('25')
      const { MAX_PARALLEL_LIMIT } = await import('@/config')
      expect(MAX_PARALLEL_LIMIT).toBe(25)
    })

    it('should fallback to default when environment variable is not set', async () => {
      setupEnvironment() // No environment variable
      const { MAX_PARALLEL_LIMIT } = await import('@/config')
      expect(MAX_PARALLEL_LIMIT).toBe(10)
    })

    it('should handle invalid environment variable values', async () => {
      setupEnvironment('invalid')
      const { MAX_PARALLEL_LIMIT } = await import('@/config')

      // Should fall back to default when parsing fails
      expect(MAX_PARALLEL_LIMIT).toBe(10)
    })

    it('should handle empty environment variable', async () => {
      setupEnvironment('')
      const { MAX_PARALLEL_LIMIT } = await import('@/config')

      // Should fall back to default when empty
      expect(MAX_PARALLEL_LIMIT).toBe(10)
    })

    // Edge cases for boundary values
    it('should clamp MAX_PARALLEL_LIMIT to MIN when env is 0 or negative', async () => {
      setupEnvironment('0')
      let { MAX_PARALLEL_LIMIT } = await import('@/config')
      expect(MAX_PARALLEL_LIMIT).toBe(10) // Falls back to default

      setupEnvironment('-5')
      ;({ MAX_PARALLEL_LIMIT } = await import('@/config'))
      expect(MAX_PARALLEL_LIMIT).toBe(10) // Falls back to default
    })

    it('should handle float numbers by parseInt behavior', async () => {
      setupEnvironment('12.7')
      const { MAX_PARALLEL_LIMIT } = await import('@/config')
      // parseInt truncates to integer
      expect(MAX_PARALLEL_LIMIT).toBe(12)
    })
  })

  describe('UI Component Integration (Main Fix Verification)', () => {
    it('should render iteration panel with environment-configured max value', async () => {
      // Set environment variable to a different value
      setupEnvironment('30')

      // Import Panel after setting environment
      const Panel = await import('@/app/components/workflow/nodes/iteration/panel').then(mod => mod.default)
      const { MAX_PARALLEL_LIMIT } = await import('@/config')

      render(
        <Panel
          id="test-node"
          // @ts-expect-error  key type mismatch
          data={mockNodeData.data}
        />,
      )

      // Behavior-focused assertion: UI max should equal MAX_PARALLEL_LIMIT
      const { numberInput, slider } = getParallelControls()
      expect(numberInput).toHaveAttribute('max', String(MAX_PARALLEL_LIMIT))
      expect(slider).toHaveAttribute('aria-valuemax', String(MAX_PARALLEL_LIMIT))

      // Verify the actual values
      expect(MAX_PARALLEL_LIMIT).toBe(30)
      expect(numberInput.getAttribute('max')).toBe('30')
      expect(slider.getAttribute('aria-valuemax')).toBe('30')
    })

    it('should maintain UI consistency with different environment values', async () => {
      setupEnvironment('15')
      const Panel = await import('@/app/components/workflow/nodes/iteration/panel').then(mod => mod.default)
      const { MAX_PARALLEL_LIMIT } = await import('@/config')

      render(
        <Panel
          id="test-node"
          // @ts-expect-error  key type mismatch
          data={mockNodeData.data}
        />,
      )

      // Both input and slider should use the same max value from MAX_PARALLEL_LIMIT
      const { numberInput, slider } = getParallelControls()

      expect(numberInput.getAttribute('max')).toBe(slider.getAttribute('aria-valuemax'))
      expect(numberInput.getAttribute('max')).toBe(String(MAX_PARALLEL_LIMIT))
    })
  })

  describe('Legacy Constant Verification (For Transition Period)', () => {
    // Marked as transition/deprecation tests
    it('should maintain MAX_ITERATION_PARALLEL_NUM for backward compatibility', async () => {
      const { MAX_ITERATION_PARALLEL_NUM } = await import('@/app/components/workflow/constants')
      expect(typeof MAX_ITERATION_PARALLEL_NUM).toBe('number')
      expect(MAX_ITERATION_PARALLEL_NUM).toBe(10) // Hardcoded legacy value
    })

    it('should demonstrate MAX_PARALLEL_LIMIT vs legacy constant difference', async () => {
      setupEnvironment('50')
      const { MAX_PARALLEL_LIMIT } = await import('@/config')
      const { MAX_ITERATION_PARALLEL_NUM } = await import('@/app/components/workflow/constants')

      // MAX_PARALLEL_LIMIT is configurable, MAX_ITERATION_PARALLEL_NUM is not
      expect(MAX_PARALLEL_LIMIT).toBe(50)
      expect(MAX_ITERATION_PARALLEL_NUM).toBe(10)
      expect(MAX_PARALLEL_LIMIT).not.toBe(MAX_ITERATION_PARALLEL_NUM)
    })
  })

  describe('Constants Validation', () => {
    it('should validate that required constants exist and have correct types', async () => {
      const { MAX_PARALLEL_LIMIT } = await import('@/config')
      const { MIN_ITERATION_PARALLEL_NUM } = await import('@/app/components/workflow/constants')
      expect(typeof MAX_PARALLEL_LIMIT).toBe('number')
      expect(typeof MIN_ITERATION_PARALLEL_NUM).toBe('number')
      expect(MAX_PARALLEL_LIMIT).toBeGreaterThanOrEqual(MIN_ITERATION_PARALLEL_NUM)
    })
  })
})