Skip to content

samebases(::AbstractOperator, ...) should use calls to basis instead of assuming internal layout for the structures #25

@Krastanov

Description

@Krastanov

See here:

samebases(a::AbstractOperator) = samebases(a.basis_l, a.basis_r)::Bool
samebases(a::AbstractOperator, b::AbstractOperator) = samebases(a.basis_l, b.basis_l)::Bool && samebases(a.basis_r, b.basis_r)::Bool
check_samebases(a::Union{AbstractOperator, AbstractSuperOperator}) = check_samebases(a.basis_l, a.basis_r)

Assuming that these structures internally have .basis fields breaks in many important cases. This should instead just use formalized interfaces like calls to basis.

This is a special case of issue #12

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions