Get all tests passing!

Author: akirakyle

Project.toml

@@ -15,7 +15,6 @@ Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
 RecursiveArrayTools = "731186ca-8d62-57ce-b412-fbd966d074cd"
 SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
 Strided = "5e0ebb24-38b0-5f93-81fe-25c709ecae67"
-TensorCast = "02d47bb6-7ce6-556a-be16-bb1710789e2b"
 UnsafeArrays = "c4a57d5a-5b31-53a6-b365-19f8c011fbd6"
 
 [compat]
@@ -31,6 +30,5 @@ Random = "1"
 RecursiveArrayTools = "3"
 SparseArrays = "1"
 Strided = "1, 2"
-TensorCast = "0.4"
 UnsafeArrays = "1"
 julia = "1.10"

src/apply.jl

@@ -23,13 +23,14 @@ function apply!(state::Operator, indices, operation::Operator)
     state
 end
 
-function apply!(state::Ket, indices, operation::T) where {T<:SuperOperatorType}
+function apply!(state::Ket, indices, operation::SuperOperatorType)
     apply!(dm(state), indices, operation)
 end
 
-function apply!(state::Operator, indices, operation::T) where {T<:SuperOperatorType}
-    if is_apply_shortcircuit(state, indices, operation)
-        state.data = (operation*state).data
+function apply!(state::Operator, indices, operation::SuperOperatorType)
+    vecd = vec(state)
+    if is_apply_shortcircuit(vecd, indices, operation)
+        state.data = unvec(operation*vecd).data
         return state
     else
         error("`apply!` does not yet support embedding superoperators acting only on a subsystem of the given state")

src/metrics.jl

@@ -254,13 +254,14 @@ logarithmic_negativity(rho::DenseOpType{B,B}, index) where B<:CompositeBasis = l
 
 The average gate fidelity between two superoperators x and y.
 """
-
-"""
-function avg_gate_fidelity(x::T, y::T) where T <: Union{PauliTransferMatrix{B, B} where B, SuperOperator{B, B} where B, ChiMatrix{B, B} where B}
-    dim = 2 ^ length(x.basis_l)
+function avg_gate_fidelity(x::T, y::T) where T <: Union{PauliTransferType, SuperOperatorType}
+    check_multiplicable(x,x); check_multiplicable(y,y)
+    check_samebases(basis_l(basis_l(x)), basis_r(basis_l(x)));
+    dim = dimension(basis_l(basis_l(x)))
     return (tr(transpose(x.data) * y.data) + dim) / (dim^2 + dim)
 end
-"""
+
+avg_gate_fidelity(x::T, y::T) where T <: Union{ChoiStateType, ChiType} = avg_gate_fidelity(super(x), super(y))
 
 """
     entanglement_entropy(state, partition, [entropy_fun=entropy_vn])

test/runtests.jl

@@ -1,4 +1,3 @@
-"""
 names = [
     "test_states.jl",
 
@@ -61,7 +60,3 @@ for name=names
         include(name)
     end
 end
-"""
-
-include("test_pauli.jl")
-#include("test_superoperators.jl")

test/test_metrics.jl

@@ -128,13 +128,13 @@ rho_mix = DenseOperator(rho_ent.basis_l, diagm(ComplexF64[1.0,1.0,1.0,1.0]))
 @test_throws ArgumentError entanglement_entropy(rho_mix, 3)
 
 CNOT = dm(spinup(b1))⊗identityoperator(b1) + dm(spindown(b1))⊗sigmax(b1)
-CNOT_sop = SuperOperator(CNOT)
-CNOT_chi = ChiMatrix(CNOT)
-CNOT_ptm = PauliTransferMatrix(CNOT)
+CNOT_sop = sprepost(CNOT, dagger(CNOT))
+CNOT_chi = chi(CNOT_sop)
+CNOT_ptm = pauli(CNOT_sop)
 
-@test avg_gate_fidelity(CNOT_sop, CNOT_sop) == 1
-@test avg_gate_fidelity(CNOT_chi, CNOT_chi) == 1
-@test avg_gate_fidelity(CNOT_ptm, CNOT_ptm) == 1
+@test avg_gate_fidelity(CNOT_sop, CNOT_sop) ≈ 1
+@test avg_gate_fidelity(CNOT_chi, CNOT_chi) ≈ 1
+@test avg_gate_fidelity(CNOT_ptm, CNOT_ptm) ≈ 1
 
 @test_throws MethodError avg_gate_fidelity(CNOT_sop, CNOT_chi)
 @test_throws MethodError avg_gate_fidelity(CNOT_sop, CNOT_ptm)