Merge pull request #125 from qonversion/feature/deprecatedUserId

Deprecated setUserId method

Author: Maria-Bordunova

android/build.gradle

@@ -3,7 +3,7 @@ version '3.4.1'
 
 buildscript {
     ext.kotlin_version = '1.3.50'
-    ext.qonversion_version = '2.11.1'
+    ext.qonversion_version = '2.11.7'
     repositories {
         google()
         jcenter()

android/src/main/kotlin/com/qonversion/flutter/sdk/qonversion_flutter_sdk/QonversionFlutterSdkPlugin.kt

@@ -4,7 +4,7 @@ import android.app.Activity
 import android.app.Application
 import android.util.Log
 import androidx.annotation.NonNull
-import androidx.preference.PreferenceManager
+import android.preference.PreferenceManager
 import com.google.gson.Gson
 import com.google.gson.JsonSyntaxException
 import com.qonversion.android.sdk.*
@@ -108,7 +108,6 @@ class QonversionFlutterSdkPlugin : MethodCallHandler, FlutterPlugin, ActivityAwa
             "purchaseProduct" -> purchaseProduct(args["product"] as? String, result)
             "updatePurchase" -> updatePurchase(args, result)
             "updatePurchaseWithProduct" -> updatePurchaseWithProduct(args, result)
-            "setUserId" -> setUserId(args["userId"] as? String, result)
             "setProperty" -> setProperty(args, result)
             "setUserProperty" -> setUserProperty(args, result)
             "addAttributionData" -> addAttributionData(args, result)
@@ -275,16 +274,6 @@ class QonversionFlutterSdkPlugin : MethodCallHandler, FlutterPlugin, ActivityAwa
         })
     }
 
-    private fun setUserId(userId: String?, result: Result) {
-        if (userId == null) {
-            result.noUserIdError()
-            return
-        }
-
-        Qonversion.setUserID(userId)
-        result.success(null)
-    }
-
     private fun setProperty(args: Map<String, Any>, result: Result) {
         val rawProperty = args["property"] as? String ?: return result.noProperty()
 

example/lib/home.dart

@@ -47,11 +47,11 @@ class _HomeViewState extends State<HomeView> {
                   Padding(
                     padding: const EdgeInsets.all(8.0),
                     child: FlatButton(
-                      child: Text('Set custom userId'),
-                      color: Colors.blue,
-                      textColor: Colors.white,
-                      onPressed: () => Qonversion.setUserId('userId'),
-                    ),
+                        child: Text('Set custom userId'),
+                        color: Colors.blue,
+                        textColor: Colors.white,
+                        onPressed: () => Qonversion.setProperty(
+                            QUserProperty.customUserId, 'userId')),
                   ),
                   Padding(
                     padding: const EdgeInsets.only(

example/lib/params_view.dart

@@ -21,8 +21,8 @@ class ParamsView extends StatelessWidget {
               child: Text('Set User ID'),
               color: Colors.green,
               textColor: Colors.white,
-              onPressed: () async {
-                await Qonversion.setUserId('customId');
+              onPressed: () {
+                Qonversion.setProperty(QUserProperty.customUserId, 'customId');
                 print('did set user id');
               },
             ),

ios/Classes/Mapper.swift

@@ -95,6 +95,9 @@ extension Qonversion.Property {
     case "KochavaDeviceId":
       return .kochavaDeviceID
 
+    case "CustomUserId":
+      return .userID
+      
     default:
       throw ParsingError.runtimeError("Could not parse Qonversion.Property")
     }

ios/Classes/SwiftQonversionFlutterSdkPlugin.swift

@@ -85,9 +85,6 @@ public class SwiftQonversionFlutterSdkPlugin: NSObject, FlutterPlugin {
     case "promoPurchase":
       return promoPurchase(args["productId"] as? String, result)
 
-    case "setUserId":
-      return setUserId(args["userId"] as? String, result)
-      
     case "addAttributionData":
       return addAttributionData(args, result)
 
@@ -249,16 +246,6 @@ public class SwiftQonversionFlutterSdkPlugin: NSObject, FlutterPlugin {
     }
   }
 
-  private func setUserId(_ userId: String?, _ result: @escaping FlutterResult) {
-    guard let userId = userId else {
-      result(FlutterError.noUserId)
-      return
-    }
-    
-    Qonversion.setUserID(userId)
-    result(nil)
-  }
-  
   private func setProperty(_ args: [String: Any], _ result: @escaping FlutterResult) {
     guard let rawProperty = args["property"] as? String else {
       return result(FlutterError.noProperty)

ios/qonversion_flutter.podspec

@@ -16,7 +16,7 @@ Pod::Spec.new do |s|
   s.source_files = 'Classes/**/*'
   s.dependency 'Flutter'
   s.platform = :ios, '9.0'
-  s.dependency 'Qonversion', '2.17.1'
+  s.dependency 'Qonversion', '2.18.1'
 
   # Flutter.framework does not contain a i386 slice. Only x86_64 simulators are supported.
   s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES', 'VALID_ARCHS[sdk=iphonesimulator*]' => 'x86_64' }

lib/src/constants.dart

@@ -27,7 +27,6 @@ class Constants {
   static const mUpdatePurchaseWithProduct = 'updatePurchaseWithProduct';
   static const mCheckPermissions = 'checkPermissions';
   static const mRestore = 'restore';
-  static const mSetUserId = 'setUserId';
   static const mSetProperty = 'setProperty';
   static const mSetUserProperty = 'setUserProperty';
   static const mSyncPurchases = 'syncPurchases';

lib/src/models/user_property.dart

@@ -4,4 +4,5 @@ enum QUserProperty {
   appsFlyerUserId,
   adjustAdId,
   kochavaDeviceId,
+  customUserId,
 }

lib/src/qonversion.dart

@@ -209,8 +209,10 @@ class Qonversion {
   /// Qonversion SDK provides an asynchronous method to set your side User ID that can be used to match users in third-party integrations.
   ///
   /// See more in [documentation](https://documentation.qonversion.io/docs/user-identifiers)
+  @Deprecated(
+      "Will be removed in a future major release. Use setProperty(QUserProperty.customUserId, 'value') instead.")
   static Future<void> setUserId(String userId) =>
-      _channel.invokeMethod(Constants.mSetUserId, {Constants.kUserId: userId});
+      setProperty(QUserProperty.customUserId, userId);
 
   /// Sets user property for pre-defined case property.
   ///