safe_atomics: Make try_atomic_add publicly visible

GIT_ORIGIN_SPP_REV_ID: 59b6a87fc7fa5d015f7628b6e250cc5174d777c7

Author: bemerybmw

score/language/safecpp/safe_atomics/BUILD

@@ -20,9 +20,7 @@ cc_library(
     hdrs = ["try_atomic_add.h"],
     features = COMPILER_WARNING_FEATURES,
     tags = ["FFI"],
-    visibility = [
-        "@score_baselibs//score/language/safecpp/safe_math:__pkg__",
-    ],
+    visibility = ["//visibility:public"],
     deps = [
         ":error",
         "@score_baselibs//score/language/safecpp/safe_math/details/addition_subtraction",

score/language/safecpp/safe_atomics/error.cpp

@@ -19,7 +19,7 @@ std::string_view score::safe_atomics::ErrorDomain::MessageFor(const score::resul
     static_assert(std::is_same_v<ResultErrorCode, std::underlying_type_t<SafeMathErrorCode>>);
 
     // Suppress "AUTOSAR C++14 A7-2-1" as false positive
-    // // Suppress "AUTOSAR C++14 M6-4-5": The `return` statement in this case clause unconditionally exits the
+    // Suppress "AUTOSAR C++14 M6-4-5": The `return` statement in this case clause unconditionally exits the
     // function, making an additional `break` statement redundant.
     // coverity[autosar_cpp14_m6_4_3_violation]
     // coverity[autosar_cpp14_a7_2_1_violation: FALSE]

score/language/safecpp/safe_atomics/try_atomic_add.h

@@ -46,7 +46,6 @@ score::Result<T> TryAtomicAddImpl(std::atomic<T>& atomic, const T addition_value
         const auto addition_result = safe_math::Add(current_value, addition_value);
         if (!(addition_result.has_value()))
         {
-
             if (addition_result.error() == safe_math::ErrorCode::kExceedsNumericLimits)
             {
                 return MakeUnexpected(ErrorCode::kExceedsNumericLimits);