Merge pull request OpenFAST#159 from OpenFAST/dev

Merge dev into main for Release v4.1.0

Author: andrew-platt

.gitignore

@@ -29,6 +29,8 @@ vtk*
 # build directories
 glue-codes/openfast/5MW_Baseline/ServoData/DISCON*/build
 
-
 # temporary figures
 _*.png
+
+# temporary python directory (only happens if running test case locally)
+__pycache__

README.rst

@@ -5,7 +5,7 @@ This repository serves as a container for regression test data for system-level
 and module-level testing of OpenFAST. The repository contains:
 
 - Input files for test case execution
-- Baseline solutions for various machine and compiler combinations
+- Baseline solutions
 - Turbine models used in the regression test cases
 
 The baseline solutions serve as "gold standards" for the regression test suite
@@ -85,21 +85,21 @@ the current test names is given below.
 Baselines
 ~~~~~~~~~
 The regression test compares locally generated solutions to the baseline
-solutions generated on a series of system and compiler combinations.
-Currently, the supported system/compiler combinations for successful
-regression testing along with the toolsets use are given below.
+solutions generated with the toolsets below.
 
 ================= ======================= ========================= ==================
  System-Compiler   System Version          Compiler                  Math Library
 ================= ======================= ========================= ==================
- windows-intel     Windows 10 V 2004       Intel OneAPI 2021         Intel MKL 2021
- linux-intel       Ubuntu 20.04 (WSL)      Intel OneAPI 2021         Intel MKL 2021
- linux-gnu         Ubuntu 20.04 (WSL)      GNU Fortran 10.2 (APT)    liblapack (APT)    
- macos-gnu         macOS 10.15.7           GNU Fortran 10.2 (Brew)   `Accelerate <https://developer.apple.com/documentation/accelerate>`_
+ GitHub actions    Ubuntu 22.04 (WSL)      GNU Fortran 12.2 (APT)    liblapack (APT)    
 ================= ======================= ========================= ==================
 
 The regression test only supports double precision solutions, so all
-baseline solutions are generated with a double precision build.
+baseline solutions are generated with a double precision build. If you run local
+testing, there may be small numerical differences from the baseline solutions
+provided that may show up as a failed test. If you plot the results, the
+resulting timeseries should match closely for most compiler and hardware
+combinations (i.e. MacOS 15.5 (M4) with GNU Fortran 14.2 (Brew) will fail only
+one test).
 
 Updating the baselines
 ----------------------
@@ -120,9 +120,9 @@ Example:
     # Move into the r-test submodule
     cd openfast/reg_tests/r-test
 
-    #       updateBaselineSolutions.py  source_directory                        target_directory     system_name           compiler_id
-    #                                                                                                Darwin,Linux,Windows  Intel,GNU
-    python  updateBaselineSolutions.py  ../build/reg_tests/glue-codes/openfast  glue-codes/openfast  Linux                 GNU
+    #       updateBaselineSolutions.py  source_directory                        target_directory   
+    #                                                                                              
+    python  updateBaselineSolutions.py  ../build/reg_tests/glue-codes/openfast  glue-codes/openfast
 
 NOTE: External ServoDyn controllers for 5MW_Baseline cases
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -147,7 +147,7 @@ architecture in the following command:
 
 .. code-block:: bash
 
-  cmake -G "Visual Studio 14 2015 Win64" ..
+  cmake -G "Visual Studio 17 2022" ..
 
 Ultimately, three ``.dll`` libraries should be compiled and placed in the
 ``5MW_Baseline`` parallel to the test cases that will be executed. For example,

glue-codes/fast-farm/5MW_Baseline/ServoData/DISCON/DISCON_SC.f90

@@ -4,12 +4,9 @@ Simulation with one turbine using precursor VTK
 False              Echo               - Echo input data to <RootName>.ech? (flag)
 FATAL              AbortLevel         - Error level when simulation should abort (string) {"WARNING", "SEVERE", "FATAL"}
 48.0               TMax               - Total run time (s) [>=0.0]
-False              UseSC              - Use a super controller? (flag)
 1                  Mod_AmbWind        - Ambient wind model (-) (switch) {1: high-fidelity precursor in VTK format, 2: one InflowWind module, 3: multiple instances of InflowWind module}
 2                  Mod_WaveField      - Wave field handling (-) (switch) {1: use individual HydroDyn inputs without adjustment, 2: adjust wave phases based on turbine offsets from farm origin}
 0                  Mod_SharedMooring  - Shared mooring system model (switch) {0: None, 3=MoorDyn}}
---- SUPER CONTROLLER --- [used only for UseSC=True]
-"unused"           SC_FileName        - Name/location of the dynamic library {.dll [Windows] or .so [Linux]} containing the Super Controller algorithms (quoated string)
 --- SHARED MOORING SYSTEM --- [used only for Mod_SharedMoor>0]
 ""                 SharedMoorFile     - Name of file containing shared mooring system input parameters (quoted string) [used only when Mod_SharedMooring > 0]
 0.04	           DT_Mooring         - Time step for farm-level mooring coupling with each turbine (s) [used only when Mod_SharedMooring > 0]