Skip to content

Commit 1fd0f4a

Browse files
committed
bugfixes
1 parent 4ef0929 commit 1fd0f4a

File tree

3 files changed

+24
-6
lines changed

3 files changed

+24
-6
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,3 +24,4 @@ tests/output*.fa
2424
r/
2525
paper
2626
tests/modified_new.ab1
27+
tests/modified_new.ab1

src/abi2fq.nim

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,13 @@ proc parseCommandLine*(): Config =
102102
echo "Error: Window size must be at least 1"
103103
quit(1)
104104
of "q", "quality":
105-
result.qualityThreshold = parseInt(val)
106-
if result.qualityThreshold < 0 or result.qualityThreshold > 60:
107-
echo "Error: Quality threshold must be between 0 and 60"
105+
if val.len > 0:
106+
result.qualityThreshold = parseInt(val)
107+
if result.qualityThreshold < 0 or result.qualityThreshold > 60:
108+
echo "Error: Quality threshold must be between 0 and 60"
109+
quit(1)
110+
else:
111+
echo "Error: Quality threshold requires a value"
108112
quit(1)
109113
of "n", "no-trim":
110114
result.noTrim = true

src/abichromatogram.nim

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,22 @@
1-
## ABIF Chromatogram Generator
2-
## ======================
3-
##
41
## This module provides functionality to generate SVG chromatograms from ABIF trace files.
52
## It renders the four fluorescence channels with base calls in a visual format that
63
## resembles the output of DNA sequencing instruments.
4+
## Command-line usage:
5+
##
6+
## .. code-block:: none
7+
## abichromatogram <trace_file.ab1> [options]
8+
##
9+
## Options:
10+
## -o, --output FILE Output SVG file (default: chromatogram.svg)
11+
## -w, --width WIDTH SVG width in pixels (default: 1200)
12+
## --height HEIGHT SVG height in pixels (default: 600)
13+
## -s, --start POS Start position (default: 0)
14+
## -e, --end POS End position (default: whole trace)
15+
## -d, --downsample FACTOR Downsample factor for visualization (default: 1)
16+
## --hide-bases Hide base calls
17+
## --debug Show debug information
18+
## -h, --help Show this help message and exit
19+
## -v, --version Show version information and exit
720
##
821
## Example usage:
922
##

0 commit comments

Comments
 (0)