Fix trade read rules to allow for completed trades to be seen by all

quagliero · quagliero · commit fa4e0da34199 · 2017-04-30T20:14:12.000+01:00
diff --git a/database.rules.json b/database.rules.json
@@ -29,7 +29,7 @@
       "$draft": {
         "$trade": {
           ".write": "root.child('drafts').child($draft).child('teams').child(auth.uid).exists()",
-          ".read": "data.child('receivingTeam').val() === auth.uid || data.child('givingTeam').val() === auth.uid"
+          ".read": "data.child('receivingTeam').val() === auth.uid || data.child('givingTeam').val() === auth.uid || data.child('status').val() === 'ACCEPTED'"
         }
       }
     },

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@`
`29`	`29`	`"$draft": {`
`30`	`30`	`"$trade": {`
`31`	`31`	`".write": "root.child('drafts').child($draft).child('teams').child(auth.uid).exists()",`
`32`		`- ".read": "data.child('receivingTeam').val() === auth.uid \|\| data.child('givingTeam').val() === auth.uid"`
	`32`	`+ ".read": "data.child('receivingTeam').val() === auth.uid \|\| data.child('givingTeam').val() === auth.uid \|\| data.child('status').val() === 'ACCEPTED'"`
`33`	`33`	`}`
`34`	`34`	`}`
`35`	`35`	`},`