recipes-connectivity: Add new recipe for Qualcomm testing utilities #1226
Conversation
This patch introduces a new recipe for qcom-ath11k-fwtest, which fetches Qualcomm ath11k firmware test utility from QArtifactory. This utility facilitates function testing and validation of ath11k firmware. Signed-off-by: Pengfei Zhang <[email protected]>
This patch introduces a new recipe for qcom-ctrl-app-dut, which fetches Qualcomm Control Application DUT utilities as a prebuilt binary package from QArtifactory. This utility is used for QuickTrack test for PMF, RACK certifications. Signed-off-by: Pengfei Zhang <[email protected]>
penzhan
requested review from
lumag,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
| DESCRIPTION = "Prebuilt ath11k firmware test and validation utility" | ||
| LICENSE = "CLOSED" | ||
|
|
||
| PBT_BUILD_DATE = "251113.1" |
There was a problem hiding this comment.
Move PBT_BUILD_DATE next to sha256sum, they will be updated together.
| @@ -0,0 +1,29 @@ | |||
| SUMMARY = "Prebuilt Qualcomm ath11k firmware test utilities" | |||
| DESCRIPTION = "Prebuilt ath11k firmware test and validation utility" | |||
| LICENSE = "CLOSED" | |||
There was a problem hiding this comment.
What kind of CLOSED? No redistribution? Don't even think of installing? Please provide some kind of licence to be applied to this package.
|
|
||
| S = "${UNPACKDIR}" | ||
|
|
||
| RDEPENDS:${PN} += "libnl libnl-genl" |
There was a problem hiding this comment.
DEPENDS = "libnl", this would let OE do its job
|
Your From doesn't match your SoB. That needs to be fixed. |
|
|
||
| # Install the prebuilt files maintaining the directory structure | ||
| install -m 0755 ${S}/usr/sbin/* ${D}${sbindir}/ | ||
| } |
There was a problem hiding this comment.
Inheriting bin_package can replace this and skip do_configure and do_compile if we only have binaries to be copied.
| ARTIFACTORY_URL = "https://qartifactory-edge.qualcomm.com/artifactory/qsc_releases/software/chip/component/wlan-service.qclinux.0.0/${PBT_BUILD_DATE}/prebuilt_yocto" | ||
| SOC_ARCH = "armv8-2a" | ||
|
|
||
| SRC_URI = "${ARTIFACTORY_URL}/qcom-ath11k-fwtest_1.0_${SOC_ARCH}.tar.gz" |
There was a problem hiding this comment.
| SRC_URI = "${ARTIFACTORY_URL}/qcom-ath11k-fwtest_1.0_${SOC_ARCH}.tar.gz" | |
| SRC_URI = "${ARTIFACTORY_URL}/qcom-ath11k-fwtest_${PV}_${SOC_ARCH}.tar.gz" |
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
What is the primary reason for not publishing the source for those apps?
| ARTIFACTORY_URL = "https://qartifactory-edge.qualcomm.com/artifactory/qsc_releases/software/chip/component/wlan-service.qclinux.0.0/${PBT_BUILD_DATE}/prebuilt_yocto" | ||
| SOC_ARCH = "armv8-2a" | ||
|
|
||
| SRC_URI = "${ARTIFACTORY_URL}/qcom-ath11k-fwtest_1.0_${SOC_ARCH}.tar.gz" |
There was a problem hiding this comment.
Please inline ${ARTIFACTORY_URL} here, as requested in other recipes.
| @@ -0,0 +1,27 @@ | |||
| SUMMARY = "Prebuilt Qualcomm Control Application DUT utilities" | |||
| DESCRIPTION = "Qualcomm Technologies Control Application for Device Under Test" | |||
| LICENSE = "CLOSED" | |||
|
|
||
| PBT_BUILD_DATE = "251028" | ||
| ARTIFACTORY_URL = "https://qartifactory-edge.qualcomm.com/artifactory/qsc_releases/software/chip/component/wlan-service.qclinux.0.0/${PBT_BUILD_DATE}/prebuilt_yocto" | ||
| SOC_ARCH = "armv8-2a" |
There was a problem hiding this comment.
inline both SOC_ARCH aind ARTIFACTORY_URL
| ARTIFACTORY_URL = "https://qartifactory-edge.qualcomm.com/artifactory/qsc_releases/software/chip/component/wlan-service.qclinux.0.0/${PBT_BUILD_DATE}/prebuilt_yocto" | ||
| SOC_ARCH = "armv8-2a" | ||
|
|
||
| SRC_URI = "${ARTIFACTORY_URL}/qcom-ctrl-app-dut_1.0_${SOC_ARCH}.tar.gz" |
| DESCRIPTION = "Qualcomm Technologies Control Application for Device Under Test" | ||
| LICENSE = "CLOSED" | ||
|
|
||
| PBT_BUILD_DATE = "251028" |
Test run workflowTest jobs for commit 98d0725
|
Test Results 14 files ± 0 27 suites +2 54m 14s ⏱️ +41s For more details on these failures, see this check. Results for commit 98d0725. ± Comparison against base commit 380250a. This pull request removes 2 tests.♻️ This comment has been updated with latest results. |
The licenses for these apps are all proprietary, so they are released to Qartifactory in a prebuilt form. These changes are based on the reference at: master...Jairaj-quic:meta-qcom:master. |
Test run workflowTest jobs for commit 98d0725
|
Still please provide proper licensing terms. Also please check your Git setup, your commits failed to pass DCO check |
4 participants
Add new recipes for Qualcomm connectivity and validation utilities from QArtifactory: