recipes-test: Add recipe for diag-router #1273
Conversation
Add new recipe for diag-router to fetch Qualcomm Diagnostics router Userspace Application from QArtifactory. This Application routes diagnostics traffic from all peripherals to different destinations.
Jairaj-quic
requested review from
lumag,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
|
LGTM |
|
|
||
| S = "${UNPACKDIR}" | ||
|
|
||
| DEPENDS += "glib-2.0 libdiag qrtr" |
There was a problem hiding this comment.
DEPENDS are build-time prerequisites, but you are not compiling.
Only installing a prebuilt binary. Using runtime dependencies should be good enough.
There was a problem hiding this comment.
Sure let me check this, might be able to cut dependencies.
There was a problem hiding this comment.
@sbanerjee-quic it is also to let OE find out library runtime dependencies. I prefer it to listing library packages in RDEPENDS.
| install -d ${D}${bindir} | ||
|
|
||
| # Install binaries | ||
| install -m 0755 ${S}/usr/bin/diag-router ${D}${bindir}/diag-router-qti |
There was a problem hiding this comment.
Why are you installing as diag-router-qti?
There was a problem hiding this comment.
To not have conflicts with diag_git.bb
There was a problem hiding this comment.
Why do we need this package if we have an open-source one? Please work on improving the OSS one
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
I'd prefer to see necessary improvements land into the open-source diag router.
|
Why do we need this proprietary version? How would you compare with the version available at https://github.com/linux-msm/diag? |
5 participants
Add new recipe for diag-router to fetch Qualcomm Diagnostics router Userspace Application from QArtifactory. This Application routes diagnostics traffic from all peripherals to different destinations.