WIP: CI: move local.conf modifications into their own yaml to make them optional #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The enables meta-xfce and friends for DISTRO='qcom-wayland' Signed-off-by: Koen Kooi <[email protected]>
Add another axis to the CI matrix: distro.name and have a companion variable to add optional extra yaml files. The DISTRO in meta-qcom-distro needs `distro.yml`, while the default Poky-that-isn't-poky-anymore does not need an extra yaml. Signed-off-by: Koen Kooi <[email protected]>
These are specific to un-breaking Poky and nodistro, no need to force them onto other DISTROs. Update github workflows to use the new yml as well. Signed-off-by: Koen Kooi <[email protected]>
koenkooi
requested review from
ndechesne,
quaresmajose,
ricardosalveti and
sbanerjee-quic
as code owners
ndechesne
reviewed
Apr 11, 2025
.github/workflows/build-yocto.yml
Outdated
| - qcom-armv7a | ||
| distro: | ||
| - name: poky/systemd | ||
| yamlfile: "" |
Contributor
There was a problem hiding this comment.
it is really a kas config file. so 'kas' would be a better name.
Contributor
There was a problem hiding this comment.
btw, it's empty, you can simply skip it.
| CONF_VERSION = "2" | ||
| INIT_MANAGER = "systemd" | ||
| PACKAGE_CLASSES = "package_ipk" | ||
| INHERIT += "buildstats buildstats-summary" |
Contributor
There was a problem hiding this comment.
the 3 INHERIT in there, I see them as 'CI' configs that we want to enforce. I think we should keep them here.
First buildstats now is required since f6cfffd, and buildhistory I would like eventually to keep a copy of all our builds, so it would be required too.
rm_work while not needed in CI with throw away instances, is really a nice user feature, which should be kept by default too.
| distro: | ||
| - name: poky/systemd | ||
| yamlfile: "" | ||
| yamlfile: 'ci/localconfmods.yml:' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #786