Fix permissions for included workflows #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 1 files 2 suites 3m 1s ⏱️ Results for commit d1e2a9e. |
Test jobs for commit d1e2a9e |
ricardosalveti
requested review from
mattface and
mwasilew
and removed request for
mwasilew
mwasilew
suggested changes
May 27, 2025
Contributor
mwasilew
left a comment
mwasilew
left a comment
There was a problem hiding this comment.
This looks good, but maybe the commits should be squashed?
.github/workflows/build-on-pr.yml
Outdated
| checks: write # debos.yml? | ||
| contents: read # debos.yml ? | ||
| packages: read # debos.yml? | ||
| pull-requests: write # debos.yml? |
Contributor
There was a problem hiding this comment.
this comes from EnricoMi reporting action.
Contributor
Author
There was a problem hiding this comment.
Ah yes, forgot to update comments in this file; fixed in latest push
.github/workflows/build-daily.yml
Outdated
| # implicitely set all other permissions to none | ||
| permissions: | ||
| contents: read | ||
| contents: read # debos.yml |
Contributor
There was a problem hiding this comment.
It's missing the permissions for the test and test reporting actions.
Contributor
Author
There was a problem hiding this comment.
This is fixed in a dedicated commit separate from the cleanups
Signed-off-by: Loïc Minier <[email protected]>
Signed-off-by: Loïc Minier <[email protected]>
Permissions in job are probably cleaner, but since we're mainly including this workflow from others, it's easier to find the intended permissions in this way. Plus other workflows currently also manage their permissions at the workflow rather than job level. Also update permissions to more complete list. Signed-off-by: Loïc Minier <[email protected]>
Signed-off-by: Loïc Minier <[email protected]>
Signed-off-by: Loïc Minier <[email protected]>
lool
force-pushed
the
fix-perms-for-included-workflows
branch
from
d1e2a9e to
bcdc331
Compare
mwasilew
approved these changes
May 27, 2025
Test jobs for commit bcdc331 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup of workflows permission handling as to identify and fix a
missing permission for build-daily that now uses test.yml.