Fix shellcheck warnings and errors

This patch fixes all shellcheck warnings and errors in existing shell
scripts. Shellcheck should not display any issues when run with the
following parameters

    shellcheck -S warning -e SC1091 SC2230 SC3043

Shellcheck version 0.9.0 was used for this patch.

Signed-off-by: Milosz Wasilewski <[email protected]>

Author: mwasilew

Runner/init_env

@@ -1,7 +1,11 @@
+#!/bin/sh
 # Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
 # SPDX-License-Identifier: BSD-3-Clause-Clear
 
 # Source this file to setup the test suite environment
-export BASEDIR=$(pwd)
-export TOOLS=$(pwd)/utils
-export SUITES=$(pwd)/suites
+BASEDIR=$(pwd)
+export BASEDIR
+TOOLS=$(pwd)/utils
+export TOOLS
+SUITES=$(pwd)/suites
+export SUITES

Runner/run-test.sh

@@ -1,12 +1,13 @@
+#!/bin/sh
+
 # Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
 # SPDX-License-Identifier: BSD-3-Clause-Clear
 
-#!/bin/sh
 # Import test suite definitions
-. $(pwd)/init_env
+. "${PWD}"/init_env
 
 #import test functions library
-. $TOOLS/functestlib.sh
+. "${TOOLS}"/functestlib.sh
 
 
 # Find test case path by name
@@ -16,8 +17,8 @@ find_test_case_by_name() {
     # Get the directory name
     dir_name_in_dir=${1##*/}
 
-    # Check if the directory name matches the user input (ignoring case)
-    if [ "${dir_name_in_dir,,}" = "$test_name" ]; then
+    # Check if the directory name matches the user input
+    if [ "${dir_name_in_dir}" = "$test_name" ]; then
       # Get the absolute path of the directory
       abs_path=$(readlink -f "$1")
       echo "$abs_path"  
@@ -53,7 +54,6 @@ execute_test_case() {
 # Function to run a specific test case by name
 run_specific_test_by_name() {
     test_name="$1"
-    test_name=${test_name,,}
     test_path=$(find_test_case_by_name ".")
     if [ -z "$test_path" ]; then
         log "Test case with name $test_name not found."

Runner/suites/Kernel/FunctionalArea/baseport/BWMON/run.sh

@@ -1,13 +1,14 @@
+#!/bin/sh
+
 # Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
 # SPDX-License-Identifier: BSD-3-Clause-Clear
 
-#!/bin/sh
 # Import test suite definitions
-. $(pwd)/init_env
+. "${PWD}"/init_env
 TESTNAME="BWMON"
 
 #import test functions library
-. $TOOLS/functestlib.sh
+. "${TOOLS}"/functestlib.sh
 test_path=$(find_test_case_by_name "$TESTNAME")
 log_info "--------------------------------------------------------------------------"
 log_info "-------------------Starting $TESTNAME Testcase----------------------------"
@@ -41,6 +42,7 @@ log_info "Comparing votes"
 
 
 incremented=true
+# shellcheck disable=SC2046
 for i in $(seq 2 $(echo "$initial_votes" | wc -l)); do
   initial_vote=$(echo "$initial_votes" | sed -n "${i}p")
   final_vote=$(echo "$final_votes" | sed -n "${i}p")

Runner/suites/Kernel/FunctionalArea/baseport/Buses/run.sh

@@ -1,13 +1,14 @@
+#!/bin/sh
+
 # Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
 # SPDX-License-Identifier: BSD-3-Clause-Clear
 
-#!/bin/sh
 # Import test suite definitions
-. $(pwd)/init_env
+. "${PWD}"/init_env
 TESTNAME="Buses"
 
 #import test functions library
-. $TOOLS/functestlib.sh
+. "${TOOLS}"/functestlib.sh
 test_path=$(find_test_case_by_name "$TESTNAME")
 log_info "-----------------------------------------------------------------------------------------"
 log_info "-------------------Starting $TESTNAME Testcase----------------------------"
@@ -26,4 +27,4 @@ else
     log_fail "$TESTNAME : Test Failed"
     echo "$TESTNAME FAIL" > $test_path/$TESTNAME.res
 fi
-log_info "-------------------Completed $TESTNAME Testcase----------------------------"
+log_info "-------------------Completed $TESTNAME Testcase----------------------------"

Runner/suites/Kernel/FunctionalArea/baseport/CPUFreq_Validation/run.sh

@@ -1,9 +1,9 @@
+#!/bin/sh
+
 # Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
 # SPDX-License-Identifier: BSD-3-Clause-Clear
 
-#!/bin/sh
-
-. "$(pwd)/init_env"
+. "${PWD}/init_env"
 TESTNAME="CPUFreq_Validation"
 . "$TOOLS/functestlib.sh"
 

Runner/suites/Kernel/FunctionalArea/baseport/GIC/run.sh

@@ -1,13 +1,14 @@
+#!/bin/sh
+
 # Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
 # SPDX-License-Identifier: BSD-3-Clause-Clear
 
-#!/bin/sh
 # Import test suite definitions
-. $(pwd)/init_env
+. "${PWD}"/init_env
 TESTNAME="GIC"
 
 #import test functions library
-. $TOOLS/functestlib.sh
+. "${TOOLS}"/functestlib.sh
 test_path=$(find_test_case_by_name "$TESTNAME")
 log_info "-----------------------------------------------------------------------------------------"
 log_info "-------------------Starting $TESTNAME Testcase----------------------------"

Runner/suites/Kernel/FunctionalArea/baseport/IPA/run.sh

@@ -1,9 +1,10 @@
+#!/bin/sh
+
 # Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
 # SPDX-License-Identifier: BSD-3-Clause-Clear
 
-#!/bin/sh
 # Import test suite definitions
-. $(pwd)/init_env
+. "${PWD}"/init_env
 TESTNAME="IPA"
 . "$TOOLS/functestlib.sh"
 test_path=$(find_test_case_by_name "$TESTNAME")

Runner/suites/Kernel/FunctionalArea/baseport/IPCC/run.sh

@@ -1,13 +1,14 @@
+#!/bin/sh
+
 # Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
 # SPDX-License-Identifier: BSD-3-Clause-Clear
 
-#!/bin/sh
 # Import test suite definitions
-. $(pwd)/init_env
+. "${PWD}"/init_env
 TESTNAME="IPCC"
 
 #import test functions library
-. $TOOLS/functestlib.sh
+. "${TOOLS}"/functestlib.sh
 test_path=$(find_test_case_by_name "$TESTNAME")
 log_info "--------------------------------------------------------------------------"
 log_info "-------------------Starting $TESTNAME Testcase----------------------------"

Runner/suites/Kernel/FunctionalArea/baseport/Interrupts/run.sh

@@ -1,14 +1,14 @@
+#!/bin/sh
+
 # Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
 # SPDX-License-Identifier: BSD-3-Clause-Clear
 
-#!/bin/sh
 # Import test suite definitions
-. $(pwd)/init_env
+. "${PWD}"/init_env
 TESTNAME="Interrupts"
 
 #import test functions library
-. $TOOLS/functestlib.sh
-test_path=$(find_test_case_by_name "$TESTNAME")
+. "${TOOLS}"/functestlib.sh
 log_info "-----------------------------------------------------------------------------------------"
 log_info "-------------------Starting $TESTNAME Testcase----------------------------"
 

Runner/suites/Kernel/FunctionalArea/baseport/MEMLAT/run.sh

@@ -1,12 +1,13 @@
+#!/bin/sh
+
 # Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
 # SPDX-License-Identifier: BSD-3-Clause-Clear
 
-#!/bin/sh
 # Import test suite definitions
-. $(pwd)/init_env
+. "${PWD}"/init_env
 TESTNAME="MEMLAT"
 #import test functions library
-. $TOOLS/functestlib.sh
+. "${TOOLS}"/functestlib.sh
 test_path=$(find_test_case_by_name "$TESTNAME")
 test_bin_path=$(find_test_case_bin_by_name "lat_mem_rd")
 log_info "-----------------------------------------------------------------------------------------"
@@ -37,6 +38,7 @@ wait
 log_info "Comparing votes..."
 
 incremented=true
+# shellcheck disable=SC2046
 for i in $(seq 1 $(echo "$initial_votes" | wc -l)); do
   initial_vote=$(echo "$initial_votes" | sed -n "${i}p")
   final_vote=$(echo "$final_votes" | sed -n "${i}p")