send-to-lava.sh: rewrite for POSIX compliance and atomic signal emission

This patch rewrites send-to-lava.sh to:
- Ensure POSIX-compliant syntax (avoiding bashisms and non-portable constructs)
- Use a temporary buffer file to accumulate signals before emitting them atomically
- Avoid dmesg interference by delaying output flush and eliminating inline prints
- Clean up temporary signal file after emission

This resolves earlier LAVA parsing issues caused by kernel messages being interleaved
with partial LAVA signal lines.

Signed-off-by: Srikanth Muppandam <[email protected]>

Author: smuppand

Runner/utils/send-to-lava.sh

@@ -1,52 +1,36 @@
 #!/bin/sh
 
 RESULT_FILE="$1"
+SIGNAL_FILE="/tmp/lava_signals_$$.log"
 
-command -v lava-test-case > /dev/null 2>&1
-lava_test_case="$?"
-command -v lava-test-set > /dev/null 2>&1
-lava_test_set="$?"
+valid_result() {
+    case "$1" in
+        PASS|FAIL|SKIP|UNKNOWN) return 0 ;;
+        *) return 1 ;;
+    esac
+}
 
-if [ -f "${RESULT_FILE}" ]; then
-    while read -r line; do
-        if echo "${line}" | grep -iq -E ".* +(pass|fail|skip|unknown)$"; then
-            test="${line%% *}"
-            result="${line##* }"
+# Collect signals in buffer
+if [ -f "$RESULT_FILE" ]; then
+    while IFS= read -r line || [ -n "$line" ]; do
+        testcase=$(echo "$line" | awk '{print $1}')
+        result=$(echo "$line" | awk '{print $NF}' | tr '[:lower:]' '[:upper:]')
+        testcase_clean=$(echo "$testcase" | tr -dc '[:alnum:]_-')
 
-            if [ "${lava_test_case}" -eq 0 ]; then
-                lava-test-case "${test}" --result "${result}"
-            else
-                echo "<TEST_CASE_ID=${test} RESULT=${result}>"
-            fi
-        elif echo "${line}" | grep -iq -E ".*+ (pass|fail|skip|unknown)+ .*+"; then
-            test="$(echo "${line}" | awk '{print $1}')"
-            result="$(echo "${line}" | awk '{print $2}')"
-            measurement="$(echo "${line}" | awk '{print $3}')"
-            units="$(echo "${line}" | awk '{print $4}')"
-
-            if [ "${lava_test_case}" -eq 0 ]; then
-                if [ -n "${units}" ]; then
-                    lava-test-case "${test}" --result "${result}" --measurement "${measurement}" --units "${units}"
-                else
-                    lava-test-case "${test}" --result "${result}" --measurement "${measurement}"
-                fi
-            else
-               echo "<TEST_CASE_ID=${test} RESULT=${result} MEASUREMENT=${measurement} UNITS=${units}>"
-            fi
-        elif echo "${line}" | grep -iq -E "^lava-test-set.*"; then
-            test_set_status="$(echo "${line}" | awk '{print $2}')"
-            test_set_name="$(echo "${line}" | awk '{print $3}')"
-            if [ "${lava_test_set}" -eq 0 ]; then
-                lava-test-set "${test_set_status}" "${test_set_name}"
-            else
-                if [ "${test_set_status}" = "start" ]; then
-                    echo "<LAVA_SIGNAL_TESTSET START ${test_set_name}>"
-                else
-                    echo "<LAVA_SIGNAL_TESTSET STOP>"
-                fi
-            fi
+        if valid_result "$result"; then
+            printf '<<<LAVA_SIGNAL_TESTCASE TEST_CASE_ID=%s RESULT=%s>>>\n' \
+                "$testcase_clean" "$result" >> "$SIGNAL_FILE"
         fi
-    done < "${RESULT_FILE}"
+    done < "$RESULT_FILE"
 else
-    echo "WARNING: result file is missing!"
+    echo "[WARNING] Result file missing: $RESULT_FILE" >&2
+fi
+
+# Emit signals in one clean atomic flush
+if [ -s "$SIGNAL_FILE" ]; then
+    sleep 1  # small delay to let dmesg calm
+    cat "$SIGNAL_FILE"
 fi
+
+# Cleanup
+rm -f "$SIGNAL_FILE"