Fastrpc Test: Eliminate architecture dependency and execute on defaul… #143
Conversation
|
Update commit message in some better way. Also update PR description |
|
The sign-off is missing from the commit. Additionally, please include more details in the commit message explaining why you want to remove the -arch dependency from the test. |
| log_info "Binary: $FASTBIN" | ||
|
|
||
| # ---------- Arch detection if needed ---------- | ||
| if [ -z "$ARCH" ]; then |
There was a problem hiding this comment.
Is there a specific reason for removing the arch support? Is it not required to run the fastrpc_test?
There was a problem hiding this comment.
yes, it's not needed
Instead of removing it, simply avoid calling --arch in your .yaml file. It defaults to v68 anyway.
…t architecture. Signed-off-by: Tharun Kumar Merugu <[email protected]>
|
Along with several others, was merged in 10726ad. |
I don't think this is the right way to close a PR, this is a public open repo. If there are any concerns, pls post it as a comment to the PR and let the change owner fix that. If you have any additional change that you want to bring, please bring it on top of this PR. |
3 participants
Fastrpc Test: Enhancing Execution by Eliminating Architecture Dependency
Description: This update simplifies the FastRPC test script by removing the need for architecture-specific dependencies. The goal is to enhance execution and portability across various platforms. This change is motivated by the necessity to streamline test execution, reducing the need for architecture specifications which have previously led to inconsistencies and unnecessary complexity in CI testing environments.
Why this change is needed: