Skip to content

Commit a82a284

Browse files
committed
gen_partition.py: rename functions for clarity
Renamed functions to better reflect their purpose: - `generate_ptool_xml` → `generate_emmc_xml` - `generate_nand_mbn_gen_xml` → `generate_nand_xml` These changes have no functional impact. Signed-off-by: Viswanath Kraleti <[email protected]>
1 parent abd0ffd commit a82a284

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

gen_partition.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -151,8 +151,7 @@ def parse_disk_entry(disk_entry):
151151
print (str(e))
152152
usage()
153153

154-
def generate_ptool_xml (disk_params, partition_entries_dict, output_xml):
155-
print("Generating ptool XML %s" %(output_xml))
154+
def generate_emmc_xml (disk_params, partition_entries_dict, output_xml):
156155
root = ET.Element("configuration")
157156
parser_instruction_text = ""
158157

@@ -175,7 +174,6 @@ def generate_ptool_xml (disk_params, partition_entries_dict, output_xml):
175174
f.write(xmlstr)
176175

177176
def generate_ufs_xml (disk_params, partition_entries_dict, output_xml):
178-
print("Generating UFS XML %s" %(output_xml))
179177
root = ET.Element("configuration")
180178
parser_instruction_text = ""
181179

@@ -207,15 +205,16 @@ def generate_ufs_xml (disk_params, partition_entries_dict, output_xml):
207205
f.write(xmlstr)
208206

209207

210-
def generate_nand_mbn_gen_xml (disk_params, partition_entry):
211-
print("Generating nand_mbn_gen XML")
208+
def generate_nand_xml (disk_params, partition_entries_dict, output_xml):
209+
print("NAND XML generation is curently not supported.")
212210

213211
def generate_partition_xml (disk_entry, partition_entries_dict, output_xml):
214212
parse_disk_entry(disk_entry)
213+
print("Generating %s XML %s" %(disk_params["type"].upper(), output_xml))
215214
if disk_params["type"] == "emmc":
216-
generate_ptool_xml(disk_params, partition_entries_dict, output_xml)
215+
generate_emmc_xml(disk_params, partition_entries_dict, output_xml)
217216
elif disk_params["type"] == "nand":
218-
generate_nand_mbn_gen_xml(disk_params, partition_entries_dict, output_xml)
217+
generate_nand_xml(disk_params, partition_entries_dict, output_xml)
219218
elif disk_params["type"] == "ufs":
220219
generate_ufs_xml(disk_params, partition_entries_dict, output_xml)
221220

0 commit comments

Comments
 (0)