local symbols that need GOT slot require dynamic relocation

got slots requested for local symbols need dynamic relocation if
building non static images

Closes #101

Change-Id: I3b4c541e3e5af7184335420b5066c06c99873d70
Signed-off-by: Shankar Easwaran <[email protected]>

Author: quic-seaswara

lib/Target/RISCV/RISCVRelocator.cpp

@@ -432,7 +432,7 @@ void RISCVRelocator::scanLocalReloc(InputFile &pInput, Relocation &pReloc,
       return;
     // If the GOT is used in statically linked binaries,
     // the GOT entry is enough and no relocation is needed.
-    CreateGOT(Obj, pReloc, false, m_Target,
+    CreateGOT(Obj, pReloc, !config().isCodeStatic(), m_Target,
               (config().codeGenType() == LinkerConfig::Exec));
     rsym->setReserved(rsym->reserved() | ReserveGOT);
     return;

test/RISCV/standalone/Relocs/LocalSymbolsGOT/Inputs/got.s

@@ -0,0 +1,8 @@
+.global _start
+
+.type _start, %function
+_start:
+la t0, data
+ret
+data:
+.word 100

test/RISCV/standalone/Relocs/LocalSymbolsGOT/LocalSymbolGOT.test

@@ -0,0 +1,11 @@
+#---LocalSymbolGOT.test--------------------- SharedLibrary------------------#
+#BEGIN_COMMENT
+#got slots requested for local symbols need dynamic relocation if building
+#non static images
+#----------------------------------------------------------------------------
+#END_COMMENT
+RUN: %clang %clangopts -fPIC -c %p/Inputs/got.s -o %t1.got.o
+RUN: %link %linkopts -shared  %t1.got.o -o %t1.so
+RUN: %readelf -r %t1.so | %filecheck %s -check-prefix=DYNREL
+
+#DYNREL: R_RISCV_RELATIVE