Commit c7cda1a
Use correct base branch for checking non-doc changes in PR CI
This commit fixes the pull-request CI workflow to use the correct base
branch when checking for non-doc changes in pull-request CI.
Until now, if a pull-request was created for qualcomm/eld/release/23.x branch
using parth/eld/SomeFeature branch, then the 'Check for non-doc
changes' step in pull-request CI will take parth/eld/SomeFeature branch
as the HEAD commit and parth/eld/release/23.x branch as the base.
The base used here is wrong and should instead be
qualcomm/eld/release/23.x.
Using incorrect base has two key issues:
- If the repository of the branch using which PR is created does not
have a branch named as the ${BASE_BRANCH} then the `git diff ...`
command will error out and the workflow will fail.
- A more serious issue is that the PR author can update his/her
${REPO}/eld/${BASE_BRANCH} such that the 'check for non-doc changes'
returns no diff and the workflow incorrectly passes without building/running
tests.
Signed-off-by: Parth Arora <partaror@qti.qualcomm.com>1 parent d40c864 commit c7cda1a
1 file changed
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
81 | | - | |
82 | | - | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
83 | 85 | | |
84 | 86 | | |
85 | 87 | | |
| |||
0 commit comments