Skip to content

eld incorrectly set the link state ActBeforePerformingLayout when it should instead set ActBeforeWritingOutput #1728

Description

@parth-07

We incorrectly set the link state LinkState::ActBeforePerformingLayout when we should set LinkState::ActBeforeWritingOutput.

In ELFObjectWriter.cpp, we have:

{
    PluginManager &PM = ThisModule.getPluginManager();
    ThisModule.setLinkState(LinkState::ActBeforePerformingLayout);
    if (!PM.callActBeforeWritingOutputHook()) {
      // Return generic error-code. Actual error is already reported!
      return make_error_code(std::errc::not_supported);
    }
  }

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions