Merge pull request #28 from quic-bjorande/for-qcom/silence-the-paperclip

qdl: Resolve the clippy issues

Author: quic-kdybcio

qdl/src/lib.rs

@@ -161,7 +161,7 @@ pub fn firehose_write<T: QdlChan>(channel: &mut T, buf: &mut [u8]) -> anyhow::Re
     let mut b = buf.to_vec();
 
     // XML can't be n * 512 bytes long by fh spec
-    if !buf.is_empty() && buf.len() % 512 == 0 {
+    if !buf.is_empty() && buf.len().is_multiple_of(512) {
         println!("{}", "INFO: Appending '\n' to outgoing XML".bright_black());
         b.push(b'\n');
     }
@@ -223,9 +223,17 @@ pub fn firehose_configure<T: QdlChan>(
 ) -> anyhow::Result<()> {
     let config = channel.fh_config();
     // Spec requirement
-    assert!(config.send_buffer_size % config.storage_sector_size == 0);
+    assert!(
+        config
+            .send_buffer_size
+            .is_multiple_of(config.storage_sector_size)
+    );
     // Sanity requirement
-    assert!(config.send_buffer_size % config.storage_sector_size == 0);
+    assert!(
+        config
+            .send_buffer_size
+            .is_multiple_of(config.storage_sector_size)
+    );
     let mut xml = firehose_xml_setup(
         "configure",
         &[

qdl/src/sahara.rs

@@ -421,7 +421,7 @@ fn sahara_dump_region<T: QdlChan>(
         bytes_read += channel.read(&mut buf)?;
 
         // Issue a dummy read to consume the ZLP
-        if channel.fh_config().backend == QdlBackend::Usb && buf.len() % 512 == 0 {
+        if channel.fh_config().backend == QdlBackend::Usb && buf.len().is_multiple_of(512) {
             let _ = channel.read(&mut []);
         }
 
@@ -536,14 +536,12 @@ pub fn sahara_run<T: QdlChan>(
                 }
             }
             SaharaCmd::SaharaDoneResp => {
-                if let SaharaPacketBody::DoneResp(req) = pkt.body {
-                    if req.status == 1 /* COMPLETE */
-                    /* 8916 bug */
-                    || images.len() == 1
-                    {
-                        println!("{}", "Loader sent. Hack away!".green());
-                        return Ok(vec![]);
-                    }
+                if let SaharaPacketBody::DoneResp(req) = pkt.body
+                    && (req.status == 1 /* COMPLETE */ /* 8916 bug */ ||
+                     images.len() == 1)
+                {
+                    println!("{}", "Loader sent. Hack away!".green());
+                    return Ok(vec![]);
                 }
             }
             SaharaCmd::SaharaCommandReady => {