refactor: allow attributes on property level to override class level attributes

Author: ThorstenSuckow

src/Quant/Core/Tests/Trait/AccessorTraitTest.php

@@ -74,11 +74,24 @@ public function testSettersAndGettersForClass(): void
 
         $this->assertSame("foo", $inst->getFoo());
         $this->assertSame("bar", $inst->getBar());
-        $this->assertSame("snafu", $inst->getSnafu());
         $this->assertSame("foobar", $inst->getFoobar());
     }
 
 
+    public function testGetSnafuModifierOverridden(): void
+    {
+        $inst = $this->createClassWithSetterAndGetterAttributes([
+            "foo" => "Hello World",
+            "bar" => "World Hello"
+        ]);
+
+        $this->expectException(BadMethodCallException::class);
+
+        /* @phpstan-ignore-next-line */
+        $inst->getSnafu();
+    }
+
+
     public function testAccessorTraitWithDifferentValues(): void
     {
         $this->expectException(ValueError::class);

src/Quant/Core/Tests/Trait/Resources/ClassHasAttributes.php

@@ -27,7 +27,7 @@ class ClassHasAttributes
     #[Setter]
     public string $foobar = "Ok";
 
-    #[Getter]
+    #[Getter(Modifier::PRIVATE)]
     private string $snafu;
 
     public function __construct(

src/Quant/Core/Trait/AccessorTrait.php

@@ -245,10 +245,9 @@ private function cachePropertiesWithAccessorAttribute(string $accessorClass): ar
                 continue;
             }
 
-            $accessorAttribute = $classAccessorAttribute;
-
+            $accessorAttribute = $property->getAttributes($accessorClass);
             if (empty($accessorAttribute)) {
-                $accessorAttribute = $property->getAttributes($accessorClass);
+                $accessorAttribute = $classAccessorAttribute;
             }
 
             if (!empty($accessorAttribute) && ($property instanceof ReflectionProperty)) {