Skip to content

Commit be1cc5e

Browse files
author
gerrymanoim
authored
Merge pull request #185 from quantopian/build-docs-macos
BLD: build docs on macOS
2 parents bcfe4d8 + 4bdb333 commit be1cc5e

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

.github/workflows/main.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,10 +87,6 @@ jobs:
8787
run: |
8888
pip install .
8989
- name: Check that docs can be built
90-
# note we don't build this on macOS because the GHA python is built with
91-
# the wrong version of macOS, confusing clang.
92-
# See: https://github.com/actions/virtual-environments/issues/696
93-
if: startsWith(matrix.os, 'ubuntu')
9490
run: |
9591
pip install sphinx sphinx_rtd_theme breathe ipython
9692
make docs

docs/source/tutorial/setup.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import ast
22
import glob
33
import os
4+
import sys
45

56
from libpy.build import LibpyExtension
67
from setuptools import find_packages, setup
@@ -16,13 +17,18 @@
1617

1718

1819
def extension(*args, **kwargs):
20+
extra_compile_args = []
21+
if sys.platform == 'darwin':
22+
extra_compile_args.append('-mmacosx-version-min=10.15')
23+
1924
return LibpyExtension(
2025
*args,
2126
optlevel=optlevel,
2227
debug_symbols=debug_symbols,
2328
werror=True,
2429
max_errors=max_errors,
2530
include_dirs=["."] + kwargs.pop("include_dirs", []),
31+
extra_compile_args=extra_compile_args,
2632
depends=glob.glob("**/*.h", recursive=True),
2733
**kwargs
2834
)

0 commit comments

Comments
 (0)