upload on failure

Author: Gerry Manoim

.github/workflows/main.yml

@@ -85,20 +85,18 @@ jobs:
         echo ::set-env name=CC::gcc-8
         echo ::set-env name=CXX::g++-8
     - name: Run the tests (osx)
-      if: startsWith(matrix.os, 'macos')
-      run: |
-        ulimit -c unlimited
-        make -j2 test
-    - name: Run the tests (ubuntu)
       if: startsWith(matrix.os, 'ubuntu')
       run: |
-        ulimit -c unlimited
         sudo chmod -R +rwx /var/crash
+    - name: Run the tests
+      run: |
+        ulimit -c unlimited
         make -j2 test
-    - uses: actions/upload-artifact@master # capture all crashes as build artifacts
+    - uses: actions/upload-artifact@v2 # capture all crashes as build artifacts
+      if: failure()
       with:
         name: crashes
-        path: /var/crash
+        path: /var/crash/
 
     - name: Check that we can still install
       run: |