MAINT Remove plt.show() and plt.close(fig). These shouldn't be required and seem to cause display problems. See #485.

Author: twiecki

pyfolio/tears.py

@@ -434,9 +434,6 @@ def create_simple_tear_sheet(returns,
     for ax in fig.axes:
         plt.setp(ax.get_xticklabels(), visible=True)
 
-    plt.show()
-    plt.close(fig)
-
 
 @plotting.customize
 def create_returns_tear_sheet(returns, positions=None,
@@ -624,11 +621,8 @@ def create_returns_tear_sheet(returns, positions=None,
     for ax in fig.axes:
         plt.setp(ax.get_xticklabels(), visible=True)
 
-    plt.show()
     if return_fig:
         return fig
-    else:
-        plt.close(fig)
 
 
 @plotting.customize
@@ -722,11 +716,8 @@ def create_position_tear_sheet(returns, positions,
     for ax in fig.axes:
         plt.setp(ax.get_xticklabels(), visible=True)
 
-    plt.show()
     if return_fig:
         return fig
-    else:
-        plt.close(fig)
 
 
 @plotting.customize
@@ -805,11 +796,8 @@ def create_txn_tear_sheet(returns, positions, transactions,
     for ax in fig.axes:
         plt.setp(ax.get_xticklabels(), visible=True)
 
-    plt.show()
     if return_fig:
         return fig
-    else:
-        plt.close(fig)
 
 
 @plotting.customize
@@ -898,11 +886,8 @@ def create_round_trip_tear_sheet(returns, positions, transactions,
 
     gs.tight_layout(fig)
 
-    plt.show()
     if return_fig:
         return fig
-    else:
-        plt.close(fig)
 
 
 @plotting.customize
@@ -980,11 +965,8 @@ def create_interesting_times_tear_sheet(
         ax.set_ylabel('Returns')
         ax.set_xlabel('')
 
-    plt.show()
     if return_fig:
         return fig
-    else:
-        plt.close(fig)
 
 
 @plotting.customize
@@ -1276,11 +1258,8 @@ def create_bayesian_tear_sheet(returns, benchmark_rets=None,
 
     gs.tight_layout(fig)
 
-    plt.show()
     if return_fig:
         return fig
-    else:
-        plt.close(fig)
 
 
 @plotting.customize
@@ -1454,16 +1433,11 @@ def create_risk_tear_sheet(positions,
         risk.plot_volume_exposures_gross(grossed_threshold, percentile,
                                          ax_vol_gross)
 
-    plt.show()
-
     for ax in fig.axes:
         plt.setp(ax.get_xticklabels(), visible=True)
 
-    plt.show()
     if return_fig:
         return fig
-    else:
-        plt.close(fig)
 
 
 @plotting.customize
@@ -1582,8 +1556,5 @@ def create_perf_attrib_tear_sheet(returns,
 
     gs.tight_layout(fig)
 
-    plt.show()
     if return_fig:
         return fig
-    else:
-        plt.close(fig)