Skip to content

Commit 0d961ad

Browse files
authored
Python 3.8 support (#3365)
Ensures that packages are python 3.8 compatible. Adds CI tests for 3.8. This was a work based on @seunomonije's investigations. Fixes #3194. Fixes #3318.
1 parent 0bb9239 commit 0d961ad

File tree

4 files changed

+252
-255
lines changed

4 files changed

+252
-255
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ jobs:
9292
name: Pytest Ubuntu
9393
strategy:
9494
matrix:
95-
python-version: [ '3.6', '3.7' ]
95+
python-version: ['3.6', '3.7', '3.8']
9696
runs-on: ubuntu-16.04
9797
steps:
9898
- uses: actions/checkout@v2
@@ -163,7 +163,7 @@ jobs:
163163
name: Pytest Windows
164164
strategy:
165165
matrix:
166-
python-version: [ '3.6', '3.7' ]
166+
python-version: [ '3.6', '3.7', '3.8' ]
167167
runs-on: windows-latest
168168
steps:
169169
- uses: actions/checkout@v2
@@ -182,7 +182,7 @@ jobs:
182182
name: Pytest MacOS
183183
strategy:
184184
matrix:
185-
python-version: [ '3.6', '3.7' ]
185+
python-version: [ '3.6', '3.7', '3.8' ]
186186
runs-on: macos-10.15
187187
steps:
188188
- uses: actions/checkout@v2

dev_tools/conf/pip-list-dev-tools.txt

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@ pytest-benchmark~=3.2.0
88
yapf~=0.27.0
99

1010
# For generating protobufs
11-
grpcio-tools~=1.24.0
11+
12+
# 1.26 is the min version that has python 3.8 wheels
13+
grpcio-tools~=1.26
1214
mypy-protobuf==1.10
1315

1416
# For uploading packages to pypi.
@@ -25,10 +27,6 @@ pypandoc
2527
myst-parser
2628
Sphinx~=3.2.0
2729

28-
# have to pin otherwise RTD fails
29-
# see https://github.com/readthedocs/readthedocs.org/issues/7492
30-
Pygments==2.6.1
31-
3230
sphinx_rtd_theme
3331
sphinx-markdown-tables
3432

@@ -37,8 +35,5 @@ nbsphinx
3735
ipython
3836
ipykernel
3937

40-
# For google notebooks
41-
google-colab
42-
4338
# For verifying rst
4439
rstcheck~=3.3.1

0 commit comments

Comments
 (0)