Add Literal type hints for IDE autocomplete #1010
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I was waiting for 3.6 and 3.7 support to be dropped before merging this (as I don't like the types being invalid in some of the versions). Now that that's happening, I've extended this change to not use the try-catch import in #1010 . Thanks for the submission! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small quality of life improvement: Literal type hints to enable IDE autocomplete.
I tried to find all cases where Literal type hints can be provided. In a few places the stubs already had
Literaltype hints, but without importingfrom typing import Literalthey did not do anything for me. I've gone ahead and addedto
dev/gen_stim_stub_file.py.For Python <=3.7 one could also consider importing
Literalfromtyping_extensions, but it's probably better not to introduce an additional dependency.