Remove extra over-mixing checks #1014
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When processing DEP1 instructions in the ErrorAnalyzer, p > 0.75 is checked in: a) undo_DEPOLARIZE1 and b) depolarize1_probability_to_independent_per_channel_probability Likewise, p > 0.9375 is checked in: c) undo_DEPOLARIZE2 and d) depolarize2_probability_to_independent_per_channel_probability I removed checks (a) and (c). I also added tests for checks (b) and (d). Let me know if this was intentional. Signed-off-by: Abbas Bracken Ziad <[email protected]>
Collaborator
|
Good eye and the change looks correct but unfortunately the redundant check was intentional, in order to give a better error message. Python users will more easily understand what to do in response to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing DEP1 instructions in the ErrorAnalyzer, p > 0.75 is checked in:
a) undo_DEPOLARIZE1 and
b) depolarize1_probability_to_independent_per_channel_probability
Likewise, p > 0.9375 is checked in:
c) undo_DEPOLARIZE2 and
d) depolarize2_probability_to_independent_per_channel_probability
I removed checks (a) and (c). I also added tests for checks (b) and (d).
Let me know if this was intentional.
Signed-off-by: Abbas Bracken Ziad [email protected]