Support events not containing an installation

This is the case of ping for instance but also of various web hooks.

Note that in this case, you can't get an installation client:

- The injected GitHub client will be the very limited application one
  (I'm even wondering if I should prevent people from using it)
- The GraphQL client cannot be injected.

For anything advanced, you will have to create your own GitHub client
with a token.

Author: gsmet

deployment/src/main/java/io/quarkiverse/githubapp/deployment/GitHubAppProcessor.java

@@ -106,6 +106,8 @@
 import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
 import io.quarkus.deployment.builditem.nativeimage.ReflectiveHierarchyBuildItem;
 import io.quarkus.gizmo.AnnotatedElement;
+import io.quarkus.gizmo.AssignableResultHandle;
+import io.quarkus.gizmo.BranchResult;
 import io.quarkus.gizmo.BytecodeCreator;
 import io.quarkus.gizmo.CatchBlockCreator;
 import io.quarkus.gizmo.ClassCreator;
@@ -554,25 +556,37 @@ private static void generateDispatcher(ClassOutput beanClassOutput,
 
         TryBlock tryBlock = dispatchMethodCreator.tryBlock();
 
-        ResultHandle gitHubRh = tryBlock.invokeVirtualMethod(
+        // if the installation id is defined, we can push the installation client
+        // if not, we have to use the very limited application client
+        AssignableResultHandle gitHubRh = tryBlock.createVariable(GitHub.class);
+        AssignableResultHandle gitHubGraphQLClientRh = tryBlock.createVariable(DynamicGraphQLClient.class);
+        BranchResult testInstallationId = tryBlock.ifNotNull(installationIdRh);
+        BytecodeCreator installationIdSet = testInstallationId.trueBranch();
+        installationIdSet.assign(gitHubRh, installationIdSet.invokeVirtualMethod(
                 MethodDescriptor.ofMethod(GitHubService.class, "getInstallationClient", GitHub.class, long.class),
-                tryBlock.readInstanceField(
+                installationIdSet.readInstanceField(
                         FieldDescriptor.of(dispatcherClassCreator.getClassName(), GITHUB_SERVICE_FIELD, GitHubService.class),
-                        tryBlock.getThis()),
-                installationIdRh);
-
-        ResultHandle gitHubGraphQLClientRh = tryBlock.loadNull();
-
+                        installationIdSet.getThis()),
+                installationIdRh));
         if (dispatchingConfiguration.requiresGraphQLClient()) {
-            gitHubGraphQLClientRh = tryBlock.invokeVirtualMethod(
+            installationIdSet.assign(gitHubGraphQLClientRh, installationIdSet.invokeVirtualMethod(
                     MethodDescriptor.ofMethod(GitHubService.class, "getInstallationGraphQLClient", DynamicGraphQLClient.class,
                             long.class),
-                    tryBlock.readInstanceField(
+                    installationIdSet.readInstanceField(
                             FieldDescriptor.of(dispatcherClassCreator.getClassName(), GITHUB_SERVICE_FIELD,
                                     GitHubService.class),
-                            tryBlock.getThis()),
-                    installationIdRh);
+                            installationIdSet.getThis()),
+                    installationIdRh));
+        } else {
+            installationIdSet.assign(gitHubGraphQLClientRh, installationIdSet.loadNull());
         }
+        BytecodeCreator installationIdNull = testInstallationId.falseBranch();
+        installationIdNull.assign(gitHubRh, installationIdNull.invokeVirtualMethod(
+                MethodDescriptor.ofMethod(GitHubService.class, "getApplicationClient", GitHub.class),
+                installationIdNull.readInstanceField(
+                        FieldDescriptor.of(dispatcherClassCreator.getClassName(), GITHUB_SERVICE_FIELD, GitHubService.class),
+                        installationIdNull.getThis())));
+        installationIdNull.assign(gitHubGraphQLClientRh, installationIdNull.loadNull());
 
         for (EventDispatchingConfiguration eventDispatchingConfiguration : dispatchingConfiguration.getEventConfigurations()
                 .values()) {

runtime/src/main/java/io/quarkiverse/githubapp/runtime/Routes.java

@@ -168,16 +168,7 @@ public Long extractInstallationId(JsonObject body) {
             }
         }
 
-        if (launchMode == LaunchMode.TEST || launchMode == LaunchMode.DEVELOPMENT) {
-            long defaultInstallationId = 1L;
-            LOG.infof(
-                    "Payload is lacking an installation ID; the payload was probably copy/pasted from GitHub's delivery history?"
-                            + " Defaulting to installation ID %s",
-                    defaultInstallationId);
-            return defaultInstallationId;
-        }
-
-        throw new IllegalStateException("Unable to extract installation id from payload");
+        return null;
     }
 
     private static String extractRepository(JsonObject body) {

testing/src/main/java/io/quarkiverse/githubapp/testing/internal/EventSenderOptionsImpl.java

@@ -29,7 +29,7 @@ final class EventSenderOptionsImpl implements EventSenderOptions {
 
     private UUID requestId;
     private UUID deliveryId;
-    private long installationId;
+    private Long installationId;
     private String payload;
     private String contentType;
 

testing/src/main/java/io/quarkiverse/githubapp/testing/internal/GitHubMockContextImpl.java

@@ -181,8 +181,8 @@ void init() {
                 .thenAnswer(invocation -> installationGraphQLClient(invocation.getArgument(0, Long.class)));
     }
 
-    void initEventStubs(long installationId) {
-        GitHub clientMock = installationClient(installationId);
+    void initEventStubs(Long installationId) {
+        GitHub clientMock = applicationOrInstallationClient(installationId);
         MockitoUtils.doWithMockedClassClassLoader(GitHub.class, () -> {
             try {
                 when(clientMock.parseEventPayload(any(), any())).thenAnswer(invocation -> {

testing/src/test/java/io/quarkiverse/githubapp/testing/internal/GitHubMockContextImplEventMocksTest.java

@@ -35,7 +35,7 @@ public static void assertionsSettings() {
     @BeforeEach
     public void init() {
         context.init();
-        context.initEventStubs(123);
+        context.initEventStubs(123L);
         client = context.installationClient(123);
     }