Skip to content

Commit 4e6a145

Browse files
committed
Make Quarkus 3.20 the minimal version
And get rid of deprecations.
1 parent 03880c9 commit 4e6a145

File tree

6 files changed

+119
-19
lines changed

6 files changed

+119
-19
lines changed

docs/modules/ROOT/pages/includes/attributes.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
:quarkus-version: 3.15.2
1+
:quarkus-version: 3.20.0
22
:quarkus-github-app-version: 2.8.5
33

44
:github-api-javadoc-root-url: https://github-api.kohsuke.org/apidocs/org/kohsuke/github

docs/modules/ROOT/pages/includes/quarkus-github-app.adoc

Lines changed: 56 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
:summaryTableId: quarkus-github-app_quarkus-github-app
21
[.configuration-legend]
32
icon:lock[title=Fixed at build time] Configuration property fixed at build time - All other configuration properties are overridable at runtime
43
[.configuration-reference.searchable, cols="80,.^10,.^10"]
@@ -9,6 +8,10 @@ h|Type
98
h|Default
109

1110
a| [[quarkus-github-app_quarkus-github-app-app-id]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-app-id[`quarkus.github-app.app-id`]##
11+
ifdef::add-copy-button-to-config-props[]
12+
config_property_copy_button:+++quarkus.github-app.app-id+++[]
13+
endif::add-copy-button-to-config-props[]
14+
1215

1316
[.description]
1417
--
@@ -28,6 +31,10 @@ endif::add-copy-button-to-env-var[]
2831
|
2932

3033
a| [[quarkus-github-app_quarkus-github-app-app-name]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-app-name[`quarkus.github-app.app-name`]##
34+
ifdef::add-copy-button-to-config-props[]
35+
config_property_copy_button:+++quarkus.github-app.app-name+++[]
36+
endif::add-copy-button-to-config-props[]
37+
3138

3239
[.description]
3340
--
@@ -47,6 +54,10 @@ endif::add-copy-button-to-env-var[]
4754
|
4855

4956
a| [[quarkus-github-app_quarkus-github-app-read-config-files-from-source-repository]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-read-config-files-from-source-repository[`quarkus.github-app.read-config-files-from-source-repository`]##
57+
ifdef::add-copy-button-to-config-props[]
58+
config_property_copy_button:+++quarkus.github-app.read-config-files-from-source-repository+++[]
59+
endif::add-copy-button-to-config-props[]
60+
5061

5162
[.description]
5263
--
@@ -64,6 +75,10 @@ endif::add-copy-button-to-env-var[]
6475
|`false`
6576

6677
a| [[quarkus-github-app_quarkus-github-app-private-key]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-private-key[`quarkus.github-app.private-key`]##
78+
ifdef::add-copy-button-to-config-props[]
79+
config_property_copy_button:+++quarkus.github-app.private-key+++[]
80+
endif::add-copy-button-to-config-props[]
81+
6782

6883
[.description]
6984
--
@@ -83,6 +98,10 @@ endif::add-copy-button-to-env-var[]
8398
|
8499

85100
a| [[quarkus-github-app_quarkus-github-app-webhook-url-path]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-webhook-url-path[`quarkus.github-app.webhook-url-path`]##
101+
ifdef::add-copy-button-to-config-props[]
102+
config_property_copy_button:+++quarkus.github-app.webhook-url-path+++[]
103+
endif::add-copy-button-to-config-props[]
104+
86105

87106
[.description]
88107
--
@@ -102,6 +121,10 @@ endif::add-copy-button-to-env-var[]
102121
|`/`
103122

104123
a| [[quarkus-github-app_quarkus-github-app-webhook-secret]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-webhook-secret[`quarkus.github-app.webhook-secret`]##
124+
ifdef::add-copy-button-to-config-props[]
125+
config_property_copy_button:+++quarkus.github-app.webhook-secret+++[]
126+
endif::add-copy-button-to-config-props[]
127+
105128

106129
[.description]
107130
--
@@ -119,6 +142,10 @@ endif::add-copy-button-to-env-var[]
119142
|
120143

121144
a| [[quarkus-github-app_quarkus-github-app-credentials-provider]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-credentials-provider[`quarkus.github-app.credentials-provider`]##
145+
ifdef::add-copy-button-to-config-props[]
146+
config_property_copy_button:+++quarkus.github-app.credentials-provider+++[]
147+
endif::add-copy-button-to-config-props[]
148+
122149

123150
[.description]
124151
--
@@ -140,6 +167,10 @@ endif::add-copy-button-to-env-var[]
140167
|
141168

142169
a| [[quarkus-github-app_quarkus-github-app-credentials-provider-name]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-credentials-provider-name[`quarkus.github-app.credentials-provider-name`]##
170+
ifdef::add-copy-button-to-config-props[]
171+
config_property_copy_button:+++quarkus.github-app.credentials-provider-name+++[]
172+
endif::add-copy-button-to-config-props[]
173+
143174

144175
[.description]
145176
--
@@ -161,6 +192,10 @@ endif::add-copy-button-to-env-var[]
161192
|
162193

163194
a| [[quarkus-github-app_quarkus-github-app-webhook-proxy-url]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-webhook-proxy-url[`quarkus.github-app.webhook-proxy-url`]##
195+
ifdef::add-copy-button-to-config-props[]
196+
config_property_copy_button:+++quarkus.github-app.webhook-proxy-url+++[]
197+
endif::add-copy-button-to-config-props[]
198+
164199

165200
[.description]
166201
--
@@ -178,6 +213,10 @@ endif::add-copy-button-to-env-var[]
178213
|
179214

180215
a| [[quarkus-github-app_quarkus-github-app-instance-endpoint]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-instance-endpoint[`quarkus.github-app.instance-endpoint`]##
216+
ifdef::add-copy-button-to-config-props[]
217+
config_property_copy_button:+++quarkus.github-app.instance-endpoint+++[]
218+
endif::add-copy-button-to-config-props[]
219+
181220

182221
[.description]
183222
--
@@ -197,6 +236,10 @@ endif::add-copy-button-to-env-var[]
197236
|`https://api.github.com`
198237

199238
a| [[quarkus-github-app_quarkus-github-app-rest-api-endpoint]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-rest-api-endpoint[`quarkus.github-app.rest-api-endpoint`]##
239+
ifdef::add-copy-button-to-config-props[]
240+
config_property_copy_button:+++quarkus.github-app.rest-api-endpoint+++[]
241+
endif::add-copy-button-to-config-props[]
242+
200243

201244
[.description]
202245
--
@@ -216,6 +259,10 @@ endif::add-copy-button-to-env-var[]
216259
|`${quarkus.github-app.instance-endpoint}`
217260

218261
a| [[quarkus-github-app_quarkus-github-app-graphql-api-endpoint]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-graphql-api-endpoint[`quarkus.github-app.graphql-api-endpoint`]##
262+
ifdef::add-copy-button-to-config-props[]
263+
config_property_copy_button:+++quarkus.github-app.graphql-api-endpoint+++[]
264+
endif::add-copy-button-to-config-props[]
265+
219266

220267
[.description]
221268
--
@@ -235,6 +282,10 @@ endif::add-copy-button-to-env-var[]
235282
|`${quarkus.github-app.instance-endpoint}/graphql`
236283

237284
a| [[quarkus-github-app_quarkus-github-app-personal-access-token]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-personal-access-token[`quarkus.github-app.personal-access-token`]##
285+
ifdef::add-copy-button-to-config-props[]
286+
config_property_copy_button:+++quarkus.github-app.personal-access-token+++[]
287+
endif::add-copy-button-to-config-props[]
288+
238289

239290
[.description]
240291
--
@@ -258,6 +309,10 @@ endif::add-copy-button-to-env-var[]
258309
|
259310

260311
a| [[quarkus-github-app_quarkus-github-app-debug-payload-directory]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-debug-payload-directory[`quarkus.github-app.debug.payload-directory`]##
312+
ifdef::add-copy-button-to-config-props[]
313+
config_property_copy_button:+++quarkus.github-app.debug.payload-directory+++[]
314+
endif::add-copy-button-to-config-props[]
315+
261316

262317
[.description]
263318
--
@@ -276,5 +331,3 @@ endif::add-copy-button-to-env-var[]
276331

277332
|===
278333

279-
280-
:!summaryTableId:

docs/modules/ROOT/pages/includes/quarkus-github-app_quarkus.github-app.adoc

Lines changed: 56 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
:summaryTableId: quarkus-github-app_quarkus-github-app
21
[.configuration-legend]
32
icon:lock[title=Fixed at build time] Configuration property fixed at build time - All other configuration properties are overridable at runtime
43
[.configuration-reference.searchable, cols="80,.^10,.^10"]
@@ -9,6 +8,10 @@ h|Type
98
h|Default
109

1110
a| [[quarkus-github-app_quarkus-github-app-app-id]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-app-id[`quarkus.github-app.app-id`]##
11+
ifdef::add-copy-button-to-config-props[]
12+
config_property_copy_button:+++quarkus.github-app.app-id+++[]
13+
endif::add-copy-button-to-config-props[]
14+
1215

1316
[.description]
1417
--
@@ -28,6 +31,10 @@ endif::add-copy-button-to-env-var[]
2831
|
2932

3033
a| [[quarkus-github-app_quarkus-github-app-app-name]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-app-name[`quarkus.github-app.app-name`]##
34+
ifdef::add-copy-button-to-config-props[]
35+
config_property_copy_button:+++quarkus.github-app.app-name+++[]
36+
endif::add-copy-button-to-config-props[]
37+
3138

3239
[.description]
3340
--
@@ -47,6 +54,10 @@ endif::add-copy-button-to-env-var[]
4754
|
4855

4956
a| [[quarkus-github-app_quarkus-github-app-read-config-files-from-source-repository]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-read-config-files-from-source-repository[`quarkus.github-app.read-config-files-from-source-repository`]##
57+
ifdef::add-copy-button-to-config-props[]
58+
config_property_copy_button:+++quarkus.github-app.read-config-files-from-source-repository+++[]
59+
endif::add-copy-button-to-config-props[]
60+
5061

5162
[.description]
5263
--
@@ -64,6 +75,10 @@ endif::add-copy-button-to-env-var[]
6475
|`false`
6576

6677
a| [[quarkus-github-app_quarkus-github-app-private-key]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-private-key[`quarkus.github-app.private-key`]##
78+
ifdef::add-copy-button-to-config-props[]
79+
config_property_copy_button:+++quarkus.github-app.private-key+++[]
80+
endif::add-copy-button-to-config-props[]
81+
6782

6883
[.description]
6984
--
@@ -83,6 +98,10 @@ endif::add-copy-button-to-env-var[]
8398
|
8499

85100
a| [[quarkus-github-app_quarkus-github-app-webhook-url-path]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-webhook-url-path[`quarkus.github-app.webhook-url-path`]##
101+
ifdef::add-copy-button-to-config-props[]
102+
config_property_copy_button:+++quarkus.github-app.webhook-url-path+++[]
103+
endif::add-copy-button-to-config-props[]
104+
86105

87106
[.description]
88107
--
@@ -102,6 +121,10 @@ endif::add-copy-button-to-env-var[]
102121
|`/`
103122

104123
a| [[quarkus-github-app_quarkus-github-app-webhook-secret]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-webhook-secret[`quarkus.github-app.webhook-secret`]##
124+
ifdef::add-copy-button-to-config-props[]
125+
config_property_copy_button:+++quarkus.github-app.webhook-secret+++[]
126+
endif::add-copy-button-to-config-props[]
127+
105128

106129
[.description]
107130
--
@@ -119,6 +142,10 @@ endif::add-copy-button-to-env-var[]
119142
|
120143

121144
a| [[quarkus-github-app_quarkus-github-app-credentials-provider]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-credentials-provider[`quarkus.github-app.credentials-provider`]##
145+
ifdef::add-copy-button-to-config-props[]
146+
config_property_copy_button:+++quarkus.github-app.credentials-provider+++[]
147+
endif::add-copy-button-to-config-props[]
148+
122149

123150
[.description]
124151
--
@@ -140,6 +167,10 @@ endif::add-copy-button-to-env-var[]
140167
|
141168

142169
a| [[quarkus-github-app_quarkus-github-app-credentials-provider-name]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-credentials-provider-name[`quarkus.github-app.credentials-provider-name`]##
170+
ifdef::add-copy-button-to-config-props[]
171+
config_property_copy_button:+++quarkus.github-app.credentials-provider-name+++[]
172+
endif::add-copy-button-to-config-props[]
173+
143174

144175
[.description]
145176
--
@@ -161,6 +192,10 @@ endif::add-copy-button-to-env-var[]
161192
|
162193

163194
a| [[quarkus-github-app_quarkus-github-app-webhook-proxy-url]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-webhook-proxy-url[`quarkus.github-app.webhook-proxy-url`]##
195+
ifdef::add-copy-button-to-config-props[]
196+
config_property_copy_button:+++quarkus.github-app.webhook-proxy-url+++[]
197+
endif::add-copy-button-to-config-props[]
198+
164199

165200
[.description]
166201
--
@@ -178,6 +213,10 @@ endif::add-copy-button-to-env-var[]
178213
|
179214

180215
a| [[quarkus-github-app_quarkus-github-app-instance-endpoint]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-instance-endpoint[`quarkus.github-app.instance-endpoint`]##
216+
ifdef::add-copy-button-to-config-props[]
217+
config_property_copy_button:+++quarkus.github-app.instance-endpoint+++[]
218+
endif::add-copy-button-to-config-props[]
219+
181220

182221
[.description]
183222
--
@@ -197,6 +236,10 @@ endif::add-copy-button-to-env-var[]
197236
|`https://api.github.com`
198237

199238
a| [[quarkus-github-app_quarkus-github-app-rest-api-endpoint]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-rest-api-endpoint[`quarkus.github-app.rest-api-endpoint`]##
239+
ifdef::add-copy-button-to-config-props[]
240+
config_property_copy_button:+++quarkus.github-app.rest-api-endpoint+++[]
241+
endif::add-copy-button-to-config-props[]
242+
200243

201244
[.description]
202245
--
@@ -216,6 +259,10 @@ endif::add-copy-button-to-env-var[]
216259
|`${quarkus.github-app.instance-endpoint}`
217260

218261
a| [[quarkus-github-app_quarkus-github-app-graphql-api-endpoint]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-graphql-api-endpoint[`quarkus.github-app.graphql-api-endpoint`]##
262+
ifdef::add-copy-button-to-config-props[]
263+
config_property_copy_button:+++quarkus.github-app.graphql-api-endpoint+++[]
264+
endif::add-copy-button-to-config-props[]
265+
219266

220267
[.description]
221268
--
@@ -235,6 +282,10 @@ endif::add-copy-button-to-env-var[]
235282
|`${quarkus.github-app.instance-endpoint}/graphql`
236283

237284
a| [[quarkus-github-app_quarkus-github-app-personal-access-token]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-personal-access-token[`quarkus.github-app.personal-access-token`]##
285+
ifdef::add-copy-button-to-config-props[]
286+
config_property_copy_button:+++quarkus.github-app.personal-access-token+++[]
287+
endif::add-copy-button-to-config-props[]
288+
238289

239290
[.description]
240291
--
@@ -258,6 +309,10 @@ endif::add-copy-button-to-env-var[]
258309
|
259310

260311
a| [[quarkus-github-app_quarkus-github-app-debug-payload-directory]] [.property-path]##link:#quarkus-github-app_quarkus-github-app-debug-payload-directory[`quarkus.github-app.debug.payload-directory`]##
312+
ifdef::add-copy-button-to-config-props[]
313+
config_property_copy_button:+++quarkus.github-app.debug.payload-directory+++[]
314+
endif::add-copy-button-to-config-props[]
315+
261316

262317
[.description]
263318
--
@@ -276,5 +331,3 @@ endif::add-copy-button-to-env-var[]
276331

277332
|===
278333

279-
280-
:!summaryTableId:

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<maven.compiler.target>17</maven.compiler.target>
2222
<maven.compiler.release>17</maven.compiler.release>
2323
<maven.compiler.parameters>true</maven.compiler.parameters>
24-
<quarkus.version>3.15.2</quarkus.version>
24+
<quarkus.version>3.20.0</quarkus.version>
2525
<compiler-plugin.version>3.13.0</compiler-plugin.version>
2626
<resource-plugin.version>3.3.1</resource-plugin.version>
2727
<dependency-plugin.version>3.8.1</dependency-plugin.version>

runtime/src/main/java/io/quarkiverse/githubapp/runtime/Routes.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
import io.quarkiverse.githubapp.runtime.signing.PayloadSignatureChecker;
2828
import io.quarkus.runtime.LaunchMode;
2929
import io.quarkus.runtime.StartupEvent;
30-
import io.quarkus.vertx.http.runtime.HttpConfiguration;
3130
import io.quarkus.vertx.web.RoutingExchange;
3231
import io.quarkus.vertx.web.runtime.RoutingExchangeImpl;
3332
import io.vertx.core.json.Json;
@@ -58,11 +57,6 @@ public class Routes {
5857
@Inject
5958
Instance<ReplayEventsRoute> replayRouteInstance;
6059

61-
@Inject
62-
HttpConfiguration httpConfig;
63-
64-
Path tmpDirectory;
65-
6660
public void init(@Observes StartupEvent startupEvent) throws IOException {
6761
if (checkedConfigProvider.debug().payloadDirectory().isPresent()) {
6862
Files.createDirectories(checkedConfigProvider.debug().payloadDirectory().get());
@@ -142,7 +136,7 @@ private void handleRequest(RoutingContext routingContext,
142136
Long installationId = extractInstallationId(payloadObject);
143137
String repository = extractRepository(payloadObject);
144138
GitHubEvent gitHubEvent = new GitHubEvent(installationId, checkedConfigProvider.appName().orElse(null), deliveryId,
145-
repository, event, action, payload, payloadObject, "true".equals(replayed) ? true : false);
139+
repository, event, action, payload, payloadObject, "true".equals(replayed));
146140

147141
if (launchMode == LaunchMode.DEVELOPMENT && replayRouteInstance.isResolvable()) {
148142
replayRouteInstance.get().pushEvent(gitHubEvent);

0 commit comments

Comments
 (0)