Avoid instantiating installation clients when not desirable

- if all events are raw events and we don't inject a GitHub client, we
  don't need an installation client
- if the event is installation.deleted, we don't have access to the
  installation anymore so we shouldn't instantiate an installation
  client

Fixes #806

Author: gsmet

deployment/src/main/java/io/quarkiverse/githubapp/deployment/DispatchingConfiguration.java

@@ -1,6 +1,7 @@
 package io.quarkiverse.githubapp.deployment;
 
 import static io.quarkiverse.githubapp.deployment.GitHubAppDotNames.DYNAMIC_GRAPHQL_CLIENT;
+import static io.quarkiverse.githubapp.deployment.GitHubAppDotNames.GITHUB;
 import static io.quarkiverse.githubapp.deployment.GitHubAppDotNames.GITHUB_EVENT;
 
 import java.util.HashSet;
@@ -55,6 +56,22 @@ public void addEventDispatchingMethod(EventDispatchingMethod eventDispatchingMet
                 .add(eventDispatchingMethod);
     }
 
+    public boolean requiresGitHubClient() {
+        for (EventDispatchingConfiguration eventDispatchingConfiguration : eventConfigurations.values()) {
+            // if any event is a GitHub API GHEventPayload (i.e. not a @RawEvent)
+            if (eventDispatchingConfiguration.getPayloadType() != null) {
+                return true;
+            }
+        }
+        for (EventDispatchingMethod eventDispatchingMethod : methods.values().stream().flatMap(Set::stream).toList()) {
+            if (eventDispatchingMethod.requiresGitHubClient()) {
+                return true;
+            }
+        }
+
+        return false;
+    }
+
     public boolean requiresGraphQLClient() {
         for (EventDispatchingMethod eventDispatchingMethod : methods.values().stream().flatMap(Set::stream).toList()) {
             if (eventDispatchingMethod.requiresGraphQLClient()) {
@@ -247,6 +264,10 @@ public boolean requiresGraphQLClient() {
             return method.parameterTypes().stream().map(Type::name).anyMatch(DYNAMIC_GRAPHQL_CLIENT::equals);
         }
 
+        public boolean requiresGitHubClient() {
+            return method.parameterTypes().stream().map(Type::name).anyMatch(GITHUB::equals);
+        }
+
         @Override
         public int compareTo(EventDispatchingMethod other) {
             int classNameCompareTo = method.declaringClass().name().compareTo(other.method.declaringClass().name());

deployment/src/main/java/io/quarkiverse/githubapp/deployment/GitHubAppProcessor.java

@@ -608,6 +608,9 @@ private static void generateDispatcher(ClassOutput beanClassOutput,
 
         ResultHandle gitHubEventRh = dispatchMethodCreator.getMethodParam(0);
 
+        ResultHandle supportsInstallationRh = dispatchMethodCreator.invokeInterfaceMethod(
+                MethodDescriptor.ofMethod(GitHubEvent.class, "supportsInstallation", boolean.class),
+                gitHubEventRh);
         ResultHandle installationIdRh = dispatchMethodCreator.invokeInterfaceMethod(
                 MethodDescriptor.ofMethod(GitHubEvent.class, "getInstallationId", Long.class),
                 gitHubEventRh);
@@ -623,45 +626,55 @@ private static void generateDispatcher(ClassOutput beanClassOutput,
 
         TryBlock tryBlock = dispatchMethodCreator.tryBlock();
 
-        // if the installation id is defined, we can push the installation client
+        // if the event supports installation, we can push the installation client
         // if not, we have to use the very limited application client
         AssignableResultHandle gitHubRh = tryBlock.createVariable(GitHub.class);
         AssignableResultHandle gitHubGraphQLClientRh = tryBlock.createVariable(DynamicGraphQLClient.class);
-        BranchResult testInstallationId = tryBlock.ifNotNull(installationIdRh);
-        BytecodeCreator installationIdSet = testInstallationId.trueBranch();
-        installationIdSet.assign(gitHubRh, installationIdSet.invokeVirtualMethod(
-                MethodDescriptor.ofMethod(GitHubService.class, "getInstallationClient", GitHub.class, long.class),
-                installationIdSet.readInstanceField(
-                        FieldDescriptor.of(dispatcherClassCreator.getClassName(), GITHUB_SERVICE_FIELD, GitHubService.class),
-                        installationIdSet.getThis()),
-                installationIdRh));
+        BranchResult testSupportsInstallation = tryBlock.ifTrue(supportsInstallationRh);
+        BytecodeCreator supportsInstallationTrue = testSupportsInstallation.trueBranch();
+        if (dispatchingConfiguration.requiresGitHubClient()) {
+            supportsInstallationTrue.assign(gitHubRh, supportsInstallationTrue.invokeVirtualMethod(
+                    MethodDescriptor.ofMethod(GitHubService.class, "getInstallationClient", GitHub.class, long.class),
+                    supportsInstallationTrue.readInstanceField(
+                            FieldDescriptor.of(dispatcherClassCreator.getClassName(), GITHUB_SERVICE_FIELD,
+                                    GitHubService.class),
+                            supportsInstallationTrue.getThis()),
+                    installationIdRh));
+        } else {
+            supportsInstallationTrue.assign(gitHubRh, supportsInstallationTrue.loadNull());
+        }
         if (dispatchingConfiguration.requiresGraphQLClient()) {
-            installationIdSet.assign(gitHubGraphQLClientRh, installationIdSet.invokeVirtualMethod(
+            supportsInstallationTrue.assign(gitHubGraphQLClientRh, supportsInstallationTrue.invokeVirtualMethod(
                     MethodDescriptor.ofMethod(GitHubService.class, "getInstallationGraphQLClient", DynamicGraphQLClient.class,
                             long.class),
-                    installationIdSet.readInstanceField(
+                    supportsInstallationTrue.readInstanceField(
                             FieldDescriptor.of(dispatcherClassCreator.getClassName(), GITHUB_SERVICE_FIELD,
                                     GitHubService.class),
-                            installationIdSet.getThis()),
+                            supportsInstallationTrue.getThis()),
                     installationIdRh));
         } else {
-            installationIdSet.assign(gitHubGraphQLClientRh, installationIdSet.loadNull());
+            supportsInstallationTrue.assign(gitHubGraphQLClientRh, supportsInstallationTrue.loadNull());
+        }
+        BytecodeCreator supportsInstallationFalse = testSupportsInstallation.falseBranch();
+        if (dispatchingConfiguration.requiresGitHubClient()) {
+            supportsInstallationFalse.assign(gitHubRh, supportsInstallationFalse.invokeVirtualMethod(
+                    MethodDescriptor.ofMethod(GitHubService.class, "getTokenOrApplicationClient", GitHub.class),
+                    supportsInstallationFalse.readInstanceField(
+                            FieldDescriptor.of(dispatcherClassCreator.getClassName(), GITHUB_SERVICE_FIELD,
+                                    GitHubService.class),
+                            supportsInstallationFalse.getThis())));
+        } else {
+            supportsInstallationFalse.assign(gitHubRh, supportsInstallationFalse.loadNull());
         }
-        BytecodeCreator installationIdNull = testInstallationId.falseBranch();
-        installationIdNull.assign(gitHubRh, installationIdNull.invokeVirtualMethod(
-                MethodDescriptor.ofMethod(GitHubService.class, "getTokenOrApplicationClient", GitHub.class),
-                installationIdNull.readInstanceField(
-                        FieldDescriptor.of(dispatcherClassCreator.getClassName(), GITHUB_SERVICE_FIELD, GitHubService.class),
-                        installationIdNull.getThis())));
         if (dispatchingConfiguration.requiresGraphQLClient()) {
-            installationIdNull.assign(gitHubGraphQLClientRh, installationIdNull.invokeVirtualMethod(
+            supportsInstallationFalse.assign(gitHubGraphQLClientRh, supportsInstallationFalse.invokeVirtualMethod(
                     MethodDescriptor.ofMethod(GitHubService.class, "getTokenGraphQLClientOrNull", DynamicGraphQLClient.class),
-                    installationIdNull.readInstanceField(
+                    supportsInstallationFalse.readInstanceField(
                             FieldDescriptor.of(dispatcherClassCreator.getClassName(), GITHUB_SERVICE_FIELD,
                                     GitHubService.class),
-                            installationIdNull.getThis())));
+                            supportsInstallationFalse.getThis())));
         } else {
-            installationIdNull.assign(gitHubGraphQLClientRh, installationIdNull.loadNull());
+            supportsInstallationFalse.assign(gitHubGraphQLClientRh, supportsInstallationFalse.loadNull());
         }
 
         for (EventDispatchingConfiguration eventDispatchingConfiguration : dispatchingConfiguration.getEventConfigurations()

runtime/src/main/java/io/quarkiverse/githubapp/GitHubEvent.java

@@ -10,6 +10,8 @@ public interface GitHubEvent {
 
     Long getInstallationId();
 
+    boolean supportsInstallation();
+
     Optional<String> getAppName();
 
     String getDeliveryId();

runtime/src/main/java/io/quarkiverse/githubapp/runtime/SimpleGitHubEvent.java

@@ -16,6 +16,8 @@
  */
 public class SimpleGitHubEvent implements GitHubEvent {
 
+    private static final String INSTALLATION_DELETED = "installation.deleted";
+
     private final Long installationId;
 
     private final Optional<String> appName;
@@ -64,6 +66,11 @@ public Long getInstallationId() {
         return installationId;
     }
 
+    @Override
+    public boolean supportsInstallation() {
+        return installationId != null && !INSTALLATION_DELETED.equals(eventAction);
+    }
+
     @Override
     public Optional<String> getAppName() {
         return appName;

runtime/src/main/java/io/quarkiverse/githubapp/runtime/telemetry/opentelemetry/OpenTelemetryDecoratedGitHubEvent.java

@@ -24,6 +24,11 @@ public Long getInstallationId() {
         return originalGitHubEvent.getInstallationId();
     }
 
+    @Override
+    public boolean supportsInstallation() {
+        return originalGitHubEvent.supportsInstallation();
+    }
+
     @Override
     public Optional<String> getAppName() {
         return originalGitHubEvent.getAppName();