Skip to content

Commit 07055db

Browse files
tomas1885geoand
authored andcommitted
Use the default LangChain4j BedrockStreamingChatModel
1 parent df28c51 commit 07055db

File tree

2 files changed

+26
-38
lines changed

2 files changed

+26
-38
lines changed

model-providers/bedrock/deployment/src/test/java/io/quarkiverse/langchain4j/bedrock/deployment/BedrockStreamingChatModelTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@
2323
import org.junit.jupiter.api.Test;
2424
import org.junit.jupiter.api.extension.RegisterExtension;
2525

26+
import dev.langchain4j.model.bedrock.BedrockStreamingChatModel;
2627
import dev.langchain4j.model.chat.StreamingChatModel;
2728
import dev.langchain4j.model.output.FinishReason;
2829
import dev.langchain4j.model.output.TokenUsage;
29-
import io.quarkiverse.langchain4j.bedrock.runtime.BedrockConverseStreamingChatModel;
3030
import io.quarkus.arc.ClientProxy;
3131
import io.quarkus.test.QuarkusUnitTest;
3232
import software.amazon.awssdk.services.bedrockruntime.model.ConversationRole;
@@ -61,7 +61,7 @@ void should_create_bedrock_model() {
6161
// when
6262

6363
// then
64-
assertThat(ClientProxy.unwrap(streamingChatModel)).isInstanceOf(BedrockConverseStreamingChatModel.class);
64+
assertThat(ClientProxy.unwrap(streamingChatModel)).isInstanceOf(BedrockStreamingChatModel.class);
6565
}
6666

6767
@Test

model-providers/bedrock/runtime/src/main/java/io/quarkiverse/langchain4j/bedrock/runtime/BedrockRecorder.java

Lines changed: 24 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -129,48 +129,36 @@ public Supplier<StreamingChatModel> streamingChatModel(final String configName)
129129

130130
var modelId = modelConfig.modelId().orElse("anthropic.claude-v2");
131131

132-
Supplier<StreamingChatModel> supplier;
133-
if (modelId.contains("anthropic")) {
134-
135-
var paramsBuilder = ChatRequestParameters.builder()
136-
.maxOutputTokens(modelConfig.maxTokens());
132+
var paramsBuilder = ChatRequestParameters.builder()
133+
.maxOutputTokens(modelConfig.maxTokens());
137134

138-
if (modelConfig.temperature().isPresent()) {
139-
paramsBuilder.temperature(modelConfig.temperature().getAsDouble());
140-
}
135+
if (modelConfig.temperature().isPresent()) {
136+
paramsBuilder.temperature(modelConfig.temperature().getAsDouble());
137+
}
141138

142-
if (modelConfig.topP().isPresent()) {
143-
paramsBuilder.topP(modelConfig.topP().getAsDouble());
144-
}
139+
if (modelConfig.topP().isPresent()) {
140+
paramsBuilder.topP(modelConfig.topP().getAsDouble());
141+
}
145142

146-
if (modelConfig.topK().isPresent()) {
147-
paramsBuilder.topK(modelConfig.topK().getAsInt());
148-
}
143+
if (modelConfig.topK().isPresent()) {
144+
paramsBuilder.topK(modelConfig.topK().getAsInt());
145+
}
149146

150-
if (modelConfig.stopSequences().isPresent()) {
151-
paramsBuilder.stopSequences(modelConfig.stopSequences().get().toArray(new String[0]));
152-
}
147+
if (modelConfig.stopSequences().isPresent()) {
148+
paramsBuilder.stopSequences(modelConfig.stopSequences().get().toArray(new String[0]));
149+
}
153150

154-
var builder = BedrockStreamingChatModel.builder()
155-
.modelId(modelConfig.modelId().orElse("anthropic.claude-v2"))
156-
.client(clientBuilder.build())
157-
.defaultRequestParameters(paramsBuilder.build());
151+
var builder = BedrockStreamingChatModel.builder()
152+
.modelId(modelConfig.modelId().orElse("anthropic.claude-v2"))
153+
.client(clientBuilder.build())
154+
.defaultRequestParameters(paramsBuilder.build());
158155

159-
supplier = new Supplier<StreamingChatModel>() {
160-
@Override
161-
public StreamingChatModel get() {
162-
return builder.build();
163-
}
164-
};
165-
} else {
166-
var client = clientBuilder.build();
167-
supplier = new Supplier<StreamingChatModel>() {
168-
@Override
169-
public StreamingChatModel get() {
170-
return new BedrockConverseStreamingChatModel(client, modelId, modelConfig);
171-
}
172-
};
173-
}
156+
Supplier<StreamingChatModel> supplier = new Supplier<StreamingChatModel>() {
157+
@Override
158+
public StreamingChatModel get() {
159+
return builder.build();
160+
}
161+
};
174162

175163
return supplier;
176164
} else {

0 commit comments

Comments
 (0)