Replies: 3 comments 3 replies
-
|
I'm on PTO so can't really look into this for the next few weeks |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
@tomas1885 I agree we should always default to LangChain4j. Do you want to open a PR? |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
I'm just contemplating on the configuration property name. As I want to keep the current behavior as the default so not to break the usage of anyone else, unless off-course we don't mind people would have to migrate to keep the old behavior |
Beta Was this translation helpful? Give feedback.
3 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
When looking at the Bedrock Implementation, I see that only if the model is anthoric we use the default lanchain4j BedrockConverseStreamingChatModel, and by looking at the original PR this seems intentional, can anyone explain the rational behind this (@holomekc)? Was this a workaround to a specific issue? I tested a couple of other models and they seems to work fine with the default Langchain4j BedrockStreamingChatModel. If not remove it completely we can at-least make it configurable.
I don't mind opening a PR, just want to get the reasoning first.
@geoand
Beta Was this translation helpful? Give feedback.
All reactions