Matheus's feedbacks

Author: cmoine-swi

server/deployment/src/main/java/io/quarkiverse/openapi/server/generator/deployment/CodegenConfig.java

@@ -13,7 +13,7 @@ public interface CodegenConfig extends ServerCodegenConfig {
     String CODEGEN_SPEC = CODEGEN_TIME_CONFIG_PREFIX + ".spec";
     String INPUT_BASE_DIR = CODEGEN_TIME_CONFIG_PREFIX + ".input-base-dir";
     String CODEGEN_REACTIVE = CODEGEN_TIME_CONFIG_PREFIX + ".reactive";
-    String GENERATE_BUILDERS = CODEGEN_TIME_CONFIG_PREFIX + ".generate-builders";
+    String GENERATE_BUILDERS = CODEGEN_TIME_CONFIG_PREFIX + ".builders";
 
     static String getBasePackagePropertyName() {
         return CODEGEN_BASE_PACKAGE;

server/deployment/src/main/java/io/quarkiverse/openapi/server/generator/deployment/ServerCodegenConfig.java

@@ -26,6 +26,12 @@ public interface ServerCodegenConfig {
     @WithDefault("false")
     boolean reactive();
 
+    /**
+     * Whether it must generate builders for properties.
+     */
+    @WithDefault("false")
+    boolean builders();
+
     /**
      * The base package to be used to generated sources.
      */

server/deployment/src/main/java/io/quarkiverse/openapi/server/generator/deployment/codegen/ApicurioCodegenWrapper.java

@@ -125,12 +125,6 @@ private Boolean getReactiveValue() {
                 .orElse(Boolean.FALSE);
     }
 
-    private Boolean getGenerateBuildersValue() {
-        return config
-                .getOptionalValue(getGenerateBuilders(), Boolean.class)
-                .orElse(Boolean.FALSE);
-    }
-
     private static JaxRsProjectSettings defaultProjectSettings() {
         JaxRsProjectSettings projectSettings = new JaxRsProjectSettings();
         projectSettings.setJavaPackage(DEFAULT_PACKAGE);

server/deployment/src/main/java/io/quarkiverse/openapi/server/generator/deployment/codegen/ConfigurableGenerationConfig.java

@@ -1,5 +1,6 @@
 package io.quarkiverse.openapi.server.generator.deployment.codegen;
 
+import io.quarkiverse.openapi.server.generator.deployment.CodegenConfig;
 import org.eclipse.microprofile.config.Config;
 import org.jsonschema2pojo.DefaultGenerationConfig;
 import org.slf4j.Logger;
@@ -13,9 +14,9 @@ public class ConfigurableGenerationConfig extends DefaultGenerationConfig {
 
     public ConfigurableGenerationConfig(Config config) {
         generateBuilders = config
-                .getOptionalValue("quarkus.openapi.generator.options.generate-builders", Boolean.class)
+                .getOptionalValue(CodegenConfig.getGenerateBuilders(), Boolean.class)
                 .orElse(Boolean.FALSE);
-        log.info("generateBuilders={}", generateBuilders);
+        log.debug("generateBuilders={}", generateBuilders);
     }
 
     @Override

server/integration-tests/builders/src/main/resources/application.properties

@@ -2,3 +2,4 @@
 quarkus.openapi.generator.spec=petstore-openapi.json
 quarkus.openapi.generator.base-package=io.petstore
 quarkus.openapi.generator.reactive=false
+quarkus.openapi.generator.builders=true

server/integration-tests/pom.xml

@@ -17,6 +17,7 @@
         <module>reactive</module>
         <module>resteasy</module>
         <module>codestarts</module>
+        <module>builders</module>
     </modules>
 
 </project>