Skip to content

Commit b4585d3

Browse files
authored
Apply suggestions from code review
1 parent 4f4744e commit b4585d3

File tree

3 files changed

+0
-23
lines changed

3 files changed

+0
-23
lines changed

client/runtime/src/test/java/io/quarkiverse/openapi/generator/providers/AbstractOpenApiSpecProviderTest.java

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -45,24 +45,9 @@ protected abstract T createProvider(String openApiSpecId, String authSchemeName,
4545
AuthConfig authConfig);
4646

4747
protected void createConfiguration() {
48-
// generatorConfig = new OpenApiGeneratorConfig();
49-
// generatorConfig.itemConfigs = new HashMap<>();
50-
// SpecItemConfig specItemConfig = new SpecItemConfig();
51-
// specItemConfig.auth = new AuthsConfig();
52-
// specItemConfig.auth.authConfigs = new HashMap<>();
53-
// authConfig = new AuthConfig();
54-
// authConfig.headerName = Optional.empty();
55-
// authConfig.tokenPropagation = Optional.of(false);
56-
// authConfig.authConfigParams = new HashMap<>();
57-
// specItemConfig.auth.authConfigs.put(AUTH_SCHEME_NAME, authConfig);
58-
// generatorConfig.itemConfigs.put(OPEN_API_FILE_SPEC_ID, specItemConfig);
5948

6049
SpecItemConfig specItemConfig = Mockito.mock(SpecItemConfig.class);
6150
AuthsConfig authsConfig = Mockito.mock(AuthsConfig.class);
62-
// Mockito.doReturn(Map.of(
63-
// OPEN_API_FILE_SPEC_ID, specItemConfig
64-
// )).when(authsConfig).authConfigs();
65-
// Mockito.doReturn(authsConfig).when(specItemConfig).auth();
6651
headers = new MultivaluedHashMap<>();
6752
Mockito.lenient().doReturn(headers).when(requestContext).getHeaders();
6853
}

client/runtime/src/test/java/io/quarkiverse/openapi/generator/providers/ApiKeyOpenApiSpecProviderTest.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,6 @@ void filterHeaderFromAuthorizationHeaderDefaultCase() throws IOException {
5757

5858
@Test
5959
void filterHeaderFromAuthorizationHeaderCase() throws IOException {
60-
// authConfig.authConfigParams.put(ApiKeyAuthenticationProvider.USE_AUTHORIZATION_HEADER_VALUE, "true");
61-
// doReturn(Map.of(
62-
// ApiKeyAuthenticationProvider.USE_AUTHORIZATION_HEADER_VALUE, "true",
63-
// ApiKeyAuthenticationProvider.API_KEY, API_KEY_VALUE
64-
// )).when(authConfig).authConfigParams();
65-
6660
doReturn(API_KEY_AUTH_HEADER_VALUE).when(requestContext).getHeaderString("Authorization");
6761
provider.filter(requestContext);
6862
assertHeader(headers, API_KEY_NAME, API_KEY_AUTH_HEADER_VALUE);

client/runtime/src/test/java/io/quarkiverse/openapi/generator/providers/BearerOpenApiSpecProviderTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,6 @@ void filterWithPropagation(String headerName,
7474
HEADER_NAME);
7575
}
7676
headers.putSingle(propagatedHeaderName, INCOMING_TOKEN);
77-
// authConfig.tokenPropagation = Optional.of(true);
78-
// authConfig.headerName = Optional.ofNullable(headerName);
7977
filter(bearerScheme, currentToken, expectedAuthorizationHeader);
8078
}
8179

0 commit comments

Comments
 (0)