Skip to content

Commit c69287e

Browse files
author
Michael Sonnleitner
committed
windows problem with colon in filename & extended test with specific spec mapping to ensure that config key is right
1 parent d8e7d8f commit c69287e

File tree

3 files changed

+15
-2
lines changed

3 files changed

+15
-2
lines changed

client/deployment/src/main/java/io/quarkiverse/openapi/generator/deployment/codegen/GAVCoordinateOpenApiSpecInputProvider.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import io.quarkus.bootstrap.prebuild.CodeGenException;
1818
import io.quarkus.deployment.CodeGenContext;
1919
import io.quarkus.maven.dependency.ResolvedDependency;
20+
import io.smallrye.config.common.utils.StringUtil;
2021

2122
public class GAVCoordinateOpenApiSpecInputProvider implements OpenApiSpecInputProvider {
2223
private static final Logger LOG = Logger.getLogger(GAVCoordinateOpenApiSpecInputProvider.class);
@@ -48,7 +49,7 @@ public List<SpecInputModel> read(CodeGenContext context) throws CodeGenException
4849
}
4950
var inputModels = new ArrayList<SpecInputModel>();
5051
for (ResolvedDependency yamlDependency : yamlDependencies) {
51-
var gacString = yamlDependency.getKey().toGacString();
52+
var gacString = StringUtil.replaceNonAlphanumericByUnderscores(yamlDependency.getKey().toGacString());
5253
var path = yamlDependency.getResolvedPaths().stream().findFirst()
5354
.orElseThrow(() -> new CodeGenException("Could not find maven path of %s.".formatted(gacString)));
5455
try {
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
quarkus.keycloak.devservices.enabled=false
22

33
quarkus.openapi-generator.codegen.artifact-id-filter=.*echo.*
4-
quarkus.openapi-generator.codegen.exclude-gavs=io.quarkiverse.openapi.generator:quarkus-openapi-generator-gav-source-echo2
4+
quarkus.openapi-generator.codegen.exclude-gavs=io.quarkiverse.openapi.generator:quarkus-openapi-generator-gav-source-echo2
5+
quarkus.openapi-generator.codegen.spec.io_quarkiverse_openapi_generator_quarkus_openapi_generator_gav_source_echo1.serializable-model=true

client/integration-tests/gav/src/test/java/io/quarkiverse/openapi/generator/it/QuarkusGAVOpenApiTest.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
import static org.assertj.core.api.Assertions.*;
44

5+
import java.io.Serializable;
6+
57
import org.junit.jupiter.api.Test;
68

79
class QuarkusGAVOpenApiTest {
@@ -13,6 +15,15 @@ void echo1IsBeingGenerated() {
1315
.doesNotThrowAnyException();
1416
}
1517

18+
@Test
19+
void echoModelIsBeingGeneratedWithSerializableInterface() {
20+
assertThatCode(() -> {
21+
Class<?> apiClass = Class.forName(
22+
"org.openapi.quarkus.io_quarkiverse_openapi_generator_quarkus_openapi_generator_gav_source_echo1.model.Echo");
23+
assertThat(apiClass.getInterfaces()).contains(Serializable.class);
24+
}).doesNotThrowAnyException();
25+
}
26+
1627
@Test
1728
void echo2IsBeingNotGenerated() {
1829
assertThatCode(

0 commit comments

Comments
 (0)