Skip to content

Commit cd63c11

Browse files
committed
Refactored VerifyGenerationTest so it tests the generation better.
1 parent 0072fac commit cd63c11

File tree

1 file changed

+16
-21
lines changed

1 file changed

+16
-21
lines changed

client/integration-tests/equals-hashcode/src/test/java/io/quarkiverse/openapi/generator/it/VerifyGenerationTest.java

Lines changed: 16 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,42 +1,37 @@
11
package io.quarkiverse.openapi.generator.it;
22

33
import static org.junit.jupiter.api.Assertions.assertEquals;
4+
import static org.junit.jupiter.api.Assertions.assertNotEquals;
45

56
import java.lang.reflect.Method;
67
import java.util.Arrays;
7-
import java.util.stream.Stream;
88

9-
import org.acme.non.equals.hashcode.model.Animal;
10-
import org.junit.jupiter.params.ParameterizedTest;
11-
import org.junit.jupiter.params.provider.Arguments;
12-
import org.junit.jupiter.params.provider.MethodSource;
9+
import org.junit.jupiter.api.Test;
1310

1411
import io.quarkus.test.junit.QuarkusTest;
1512

1613
@QuarkusTest
1714
class VerifyGenerationTest {
1815

19-
@ParameterizedTest
20-
@MethodSource("provideStringsForIsBlank")
21-
void verify(Class<?> clazz, String methodName, Class<?> expectedDeclaringClass) {
22-
var equalsMethod = getMethod(clazz, methodName);
16+
@Test
17+
void verifyThatGeneratedModelDoesntHaveMethods() {
18+
var equalsMethod = getMethod(org.acme.equals.hashcode.model.Animal.class, "equals");
19+
var hashCodeMethod = getMethod(org.acme.equals.hashcode.model.Animal.class, "hashCode");
2320

24-
Class<?> declaringClass = equalsMethod.getDeclaringClass();
25-
26-
assertEquals(declaringClass, expectedDeclaringClass);
21+
assertEquals(equalsMethod.getDeclaringClass(), org.acme.equals.hashcode.model.Animal.class);
22+
assertEquals(hashCodeMethod.getDeclaringClass(), org.acme.equals.hashcode.model.Animal.class);
2723
}
2824

29-
private static Stream<Arguments> provideStringsForIsBlank() {
30-
return Stream.of(
31-
Arguments.of(Animal.class, "equals", Object.class),
32-
Arguments.of(Animal.class, "hashCode", Object.class),
33-
Arguments.of(org.acme.equals.hashcode.model.Animal.class, "equals",
34-
org.acme.equals.hashcode.model.Animal.class),
35-
Arguments.of(org.acme.equals.hashcode.model.Animal.class, "hashCode",
36-
org.acme.equals.hashcode.model.Animal.class));
25+
@Test
26+
void verifyThatGeneratedModelDoesHaveMethods() {
27+
var equalsMethod = getMethod(org.acme.non.equals.hashcode.model.Animal.class, "equals");
28+
var hashCodeMethod = getMethod(org.acme.non.equals.hashcode.model.Animal.class, "hashCode");
29+
30+
assertNotEquals(equalsMethod.getDeclaringClass(), org.acme.equals.hashcode.model.Animal.class);
31+
assertNotEquals(hashCodeMethod.getDeclaringClass(), org.acme.equals.hashcode.model.Animal.class);
3732
}
3833

39-
public static Method getMethod(Class<?> clazz, String methodName) {
34+
private static Method getMethod(Class<?> clazz, String methodName) {
4035
var methods = clazz.getMethods();
4136

4237
return Arrays.stream(methods)

0 commit comments

Comments
 (0)