discriminator seems not to be supported to manage polymorphism

[hbelmiro]

Discussed in #518

^{Originally posted by mexavier October 9, 2023}
Hi

I use quarkus-openapi-generator with a contract first approach for a new project. The team has a 6-month experience with quarkus.

However we failed to manage correctly polymorphism with quarkus-openapi-generator. The goal is to have operations that can manage multiple sub-types in the request or response.
We tried to use the discriminator keyword on setting it on the parent class and specifying the children implementations in the mapping part.

Hereunder is a exerpt :

    CloudEvent:
      type: object
      discriminator:
        propertyName: type
        mapping:
            CloudEventChild1: '#/components/schemas/CloudEventChild1'
            CloudEventChild2: '#/components/schemas/CloudEventChild2'
      properties:
        specVersion:
          $ref: '#/components/schemas/SpecVersion'
        id:
          type: string
        type:
          type: string
        source:
          format: uri
          type: string
        dataContentType:
          type: string
        dataSchema:
          format: uri
          type: string
        subject:
          type: string
        time:
          format: date-time
          type: string
        attributeNames:
          uniqueItems: true
          type: array
          items:
            type: string
        extensionNames:
          uniqueItems: true
          type: array
          items:
            type: string
        data:
          $ref: '#/components/schemas/CloudEventData'
    CloudEventChild1:
      type: object
      allOf:
        - $ref: '#/components/schemas/CloudEvent'
      properties:
        child1:
          type: string
    CloudEventChild2:
      type: object
      allOf:
          - $ref: '#/components/schemas/CloudEvent'
      properties:
          child2:
            type: string

When I generate the classes the classes does not hold the annotations @JsonTypeInfo and @JsonSubTypes managed by Jackson.

If do the same with "openapi generator 6" with jaxrs-resteasy, the generated class holds correcly those annotations :

@javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaResteasyServerCodegen", date = "2023-10-09T12:40:51.890826200+02:00[Europe/Zurich]")@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, include = JsonTypeInfo.As.PROPERTY, property = "type", visible = true)
@JsonSubTypes({
  @JsonSubTypes.Type(value = CloudEventChild1.class, name = "CloudEventChild1"),
  @JsonSubTypes.Type(value = CloudEventChild2.class, name = "CloudEventChild2"),
})

public class CloudEvent   {
...

Is it a limitation of the Quarkus OpenApi Generator or is there an other way to manage polymorphism ?

Thank you.

Xavier

[hbelmiro]

cc @mexavier

[wesleysalimansdvb]

@ricardozanini @hbelmiro is anyone working in implementing this feature, I would love to use this functionality :)

[hbelmiro]

@wesleysalimansdvb AFAIK no one is currently working on this. Feel free to send a PR.

[gerardbosch]

Hi @hbelmiro, did the above merge #830 fix this issue? Is the merge released or how can I use it? Thx!

[ricardozanini]

@gerardbosch we have a pacing of release. As I mentioned in the PR, I'll evaluate a release today.

[gerardbosch]

Thank you @ricardozanini! But does #830 fix this ticket? I'm understanding that yes, but as it is still open I would appreciate you could confirm (and maybe close this as fixed if that's the case 🙂)

[ricardozanini]

@gerardbosch, thanks for bringing this to my attention; yes, it solves it was not linked to the issue by mistake. Closing it :)